From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 207DEC48BCD for ; Wed, 9 Jun 2021 13:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09B6D613AE for ; Wed, 9 Jun 2021 13:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236374AbhFIN0t (ORCPT ); Wed, 9 Jun 2021 09:26:49 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:33419 "EHLO mail-wm1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231254AbhFIN0q (ORCPT ); Wed, 9 Jun 2021 09:26:46 -0400 Received: by mail-wm1-f53.google.com with SMTP id s70-20020a1ca9490000b02901a589651424so3224511wme.0 for ; Wed, 09 Jun 2021 06:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lP2ITBV7zRm5ag9NRrSPl6Qm8uDsIEGXg/GTfJ0e8kU=; b=KK0oiU/t558sncv3jMwVG6ULytasfYiT98qny4LgoNaCN4ZSgD6PwE+DZj2cOWMt4s Bz+mSAotwP41jlg3HXkiJRfKh0A4/m2EqFbxkK5BBSMm+XwzJTWAx71qNB99UH4D86ki HuAHbEHk9hJjNZyk82WLiaiYEyDWgjGEpNIHeVhoUAdMvrVpH6ZkZ83qyfWAlgpnnCSi 6DrcGcTl8TKtFWS/aJH4M7bLQcr6GuzDznE+5LiawcuKF+wp6veX+6OTHBOiusJBBgzU 23d33dn1akI3nRLlFyZ6ZtAw9/lLSZ/NV3dpDs4hNPtDXQ9nbYzUUjQGJIGbmwX4Bb5D U5Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lP2ITBV7zRm5ag9NRrSPl6Qm8uDsIEGXg/GTfJ0e8kU=; b=gvFQ958V0ewE+jl7P2EkoaVQj0vfpc1mNeNuqg5DJbbHyyZoO9F4i3LwsJbUn46kDI sQmEuv8ZfnVrW4goyBYkXWj7K53fGngHkdVb3inK/8Mx0yfPmitWThnAvSYnOjNF46mm rjhu97CphpnobIAV84M5EoaplJGYz0SxDdkh5bCWQGXbQeVaR2sn22cUzxww3ZwhIJI/ lJEfwkMFYFI27C/QeNUCnWU3UhxPIyWd9UxMu79t5M8nJvHgVYQepfpf4tNblZXZGjO1 D387oJ5t1GatkeFUdJ5K2Nq6ErM1Ko6UsEUlNH5lm2xiyutvAiF6B1AaD5P3thzq2dSe SkEA== X-Gm-Message-State: AOAM5323XrUQyKDe7ChXBL1/IRXAjKH9+n9f5LCwES+e4UOI/Syf+PbV 6jOjzK0GrIns6CLgqegIhjw= X-Google-Smtp-Source: ABdhPJx/b5jPlSGViDVrOKwFkkoGyNC7ZtT0/PWdyiyLa/U64F0l7hYPf+1VTBXpCJjIQLtSoc5Kbg== X-Received: by 2002:a05:600c:4e8e:: with SMTP id f14mr9624626wmq.172.1623245031597; Wed, 09 Jun 2021 06:23:51 -0700 (PDT) Received: from linux.local (host-82-59-55-132.retail.telecomitalia.it. [82.59.55.132]) by smtp.gmail.com with ESMTPSA id f5sm27793994wrf.22.2021.06.09.06.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 06:23:51 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Joe Perches , Fabio Aiuto , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH v2] staging: rtl8723bs: os_dep: Remove conditions with no effects Date: Wed, 9 Jun 2021 15:23:46 +0200 Message-Id: <20210609132346.15403-1-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Removed conditions with no effects. Detected by Coccinelle. Deleted a variable that is no longer used because of the above-mentioned removals. Signed-off-by: Fabio M. De Francesco Reviewed-by: Fabio Aiuto --- v1->v2: As reported by Greg Kroah-Hartman , deleted a variable that became unused because of the removal of the conditions. drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 213ec5b4ce98..11b9a5919da4 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1187,10 +1187,7 @@ void rtw_suspend_common(struct adapter *padapter) rtw_ps_deny_cancel(padapter, PS_DENY_SUSPEND); - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) - rtw_suspend_normal(padapter); - else - rtw_suspend_normal(padapter); + rtw_suspend_normal(padapter); netdev_dbg(padapter->pnetdev, "rtw suspend success in %d ms\n", jiffies_to_msecs(jiffies - start_time)); @@ -1264,15 +1261,10 @@ int rtw_resume_common(struct adapter *padapter) int ret = 0; unsigned long start_time = jiffies; struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter); - struct mlme_priv *pmlmepriv = &padapter->mlmepriv; netdev_dbg(padapter->pnetdev, "resume start\n"); - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { - rtw_resume_process_normal(padapter); - } else { - rtw_resume_process_normal(padapter); - } + rtw_resume_process_normal(padapter); hal_btcoex_SuspendNotify(padapter, 0); -- 2.31.1