From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1A9C48BDF for ; Thu, 10 Jun 2021 21:11:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8421261263 for ; Thu, 10 Jun 2021 21:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230394AbhFJVNo convert rfc822-to-8bit (ORCPT ); Thu, 10 Jun 2021 17:13:44 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49980 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhFJVNn (ORCPT ); Thu, 10 Jun 2021 17:13:43 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id AA6424F7DFB91; Thu, 10 Jun 2021 14:11:46 -0700 (PDT) Date: Thu, 10 Jun 2021 14:11:42 -0700 (PDT) Message-Id: <20210610.141142.1384244468678097702.davem@davemloft.net> To: hbut_tan@163.com Cc: elder@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tanzhongjun@yulong.com Subject: Re: [PATCH] soc: qcom: ipa: Remove superfluous error message around platform_get_irq() From: David Miller In-Reply-To: <20210610140118.1437-1-hbut_tan@163.com> References: <20210610140118.1437-1-hbut_tan@163.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Thu, 10 Jun 2021 14:11:46 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From:  Zhongjun Tan Date: Thu, 10 Jun 2021 22:01:18 +0800 > diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c > index 34b68dc43886..93270e50b6b3 100644 > --- a/drivers/net/ipa/ipa_smp2p.c > +++ b/drivers/net/ipa/ipa_smp2p.c > @@ -177,11 +177,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name, > int ret; > > ret = platform_get_irq_byname(smp2p->ipa->pdev, name); > - if (ret <= 0) { > - dev_err(dev, "DT error %d getting \"%s\" IRQ property\n", > - ret, name); > + if (ret <= 0) Applied, but this code still rejects an irq of zero which is a valid irq number.