mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: frederic@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Question about a8ea6fc9b089 ("sched: Stop PF_NO_SETAFFINITY from being inherited by various init system threads")
Date: Thu, 10 Jun 2021 10:04:35 -0700	[thread overview]
Message-ID: <20210610170435.GA2187550@paulmck-ThinkPad-P17-Gen-1> (raw)

Hello, Frederic,

This commit works well, but has the unfortunate side-effect of making
smp_processor_id() complain when used in a preemptible region even
though the kthread has been pinned onto a single CPU by a call to
set_cpus_allowed_ptr().  (Which did return success.)

This isn't a big deal -- I can easily switch to raw_smp_processor_id(),
which is arguably a better choice anyway because it prevents the
complaints from flooding out any real warnings due to error returns
from set_cpus_allowed_ptr() or something else unpinning the kthread.
Which I am in the process of doing:

516e52e9f5ec ("scftorture: Avoid excess warnings")
475d6d49f21d ("refscale: Avoid excess warnings in ref_scale_reader()")

But I figured that I should check to see if this change was in fact
intentional.

							Thanx, Paul

             reply	other threads:[~2021-06-10 17:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 17:04 Paul E. McKenney [this message]
2021-06-10 18:28 ` Valentin Schneider
2021-06-10 20:17   ` Paul E. McKenney
2021-06-11 10:12     ` Valentin Schneider
2021-06-11 13:52       ` Paul E. McKenney
2021-06-11 14:19         ` Valentin Schneider
2021-06-11 17:10           ` Paul E. McKenney
2021-06-11 12:42     ` Frederic Weisbecker
2021-06-11 17:11       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610170435.GA2187550@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®