From: Herbert Xu <herbert@gondor.apana.org.au>
To: Hongbo Li <herbert.tencent@gmail.com>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
ebiggers@kernel.org, dhowells@redhat.com, jarkko@kernel.org,
tianjia.zhang@linux.alibaba.com, herberthbli@tencent.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: sm2 - fix a memory leak in sm2
Date: Fri, 11 Jun 2021 15:23:35 +0800 [thread overview]
Message-ID: <20210611072335.GG23016@gondor.apana.org.au> (raw)
In-Reply-To: <1622788235-10739-1-git-send-email-herbert.tencent@gmail.com>
On Fri, Jun 04, 2021 at 02:30:35PM +0800, Hongbo Li wrote:
> From: Hongbo Li <herberthbli@tencent.com>
>
> SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
> test_akcipher_one(), it will set public key for every test vector,
> and don't free ec->Q. This will cause a memory leak.
>
> This patch alloc ec->Q in sm2_ec_ctx_init().
>
> Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
> Signed-off-by: Hongbo Li <herberthbli@tencent.com>
> Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
> crypto/sm2.c | 24 ++++++++++--------------
> 1 file changed, 10 insertions(+), 14 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-06-11 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 6:30 Hongbo Li
2021-06-11 7:23 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611072335.GG23016@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=herbert.tencent@gmail.com \
--cc=herberthbli@tencent.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®