From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F7BC48BE5 for ; Fri, 11 Jun 2021 18:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59D3F61357 for ; Fri, 11 Jun 2021 18:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230380AbhFKSCk (ORCPT ); Fri, 11 Jun 2021 14:02:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:41668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbhFKSCh (ORCPT ); Fri, 11 Jun 2021 14:02:37 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1438F61357; Fri, 11 Jun 2021 18:00:36 +0000 (UTC) Date: Fri, 11 Jun 2021 19:02:31 +0100 From: Jonathan Cameron To: Oleksij Rempel Cc: William Breathitt Gray , linux@rempel-privat.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] counter: interrupt-cnt: Add const qualifier for actions_list array Message-ID: <20210611190231.57adf09f@jic23-huawei> In-Reply-To: <20210610032347.wb4wcwr37p7qn7j7@pengutronix.de> References: <20210610013642.149961-1-vilhelm.gray@gmail.com> <20210610032347.wb4wcwr37p7qn7j7@pengutronix.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Jun 2021 05:23:47 +0200 Oleksij Rempel wrote: > Hi William, > > On Thu, Jun 10, 2021 at 10:36:42AM +0900, William Breathitt Gray wrote: > > The struct counter_synapse actions_list member expects a const enum > > counter_synapse_action array. This patch renames > > interrupt_cnt_synapse_actionss to interrupt_cnt_synapse_actions and adds > > a const qualifier to match actions_list. > > > > Cc: Oleksij Rempel > > Signed-off-by: William Breathitt Gray > > Reviewed-by: Applied to the togreg branch of iio.git and pushed out as testing for 0-day to see if it can find anything we missed. Thanks, Jonathan > > thank you! > > > --- > > drivers/counter/interrupt-cnt.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c > > index 827d785e19b4..5df7cd13d4c7 100644 > > --- a/drivers/counter/interrupt-cnt.c > > +++ b/drivers/counter/interrupt-cnt.c > > @@ -77,7 +77,7 @@ static const struct counter_count_ext interrupt_cnt_ext[] = { > > }, > > }; > > > > -static enum counter_synapse_action interrupt_cnt_synapse_actionss[] = { > > +static const enum counter_synapse_action interrupt_cnt_synapse_actions[] = { > > COUNTER_SYNAPSE_ACTION_RISING_EDGE, > > }; > > > > @@ -194,8 +194,8 @@ static int interrupt_cnt_probe(struct platform_device *pdev) > > priv->counter.signals = &priv->signals; > > priv->counter.num_signals = 1; > > > > - priv->synapses.actions_list = interrupt_cnt_synapse_actionss; > > - priv->synapses.num_actions = ARRAY_SIZE(interrupt_cnt_synapse_actionss); > > + priv->synapses.actions_list = interrupt_cnt_synapse_actions; > > + priv->synapses.num_actions = ARRAY_SIZE(interrupt_cnt_synapse_actions); > > priv->synapses.signal = &priv->signals; > > > > priv->cnts.name = "Channel 0 Count"; > > -- > > 2.32.0 > > > > > > >