From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60194C48BD1 for ; Fri, 11 Jun 2021 20:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49EFC613C6 for ; Fri, 11 Jun 2021 20:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbhFKUnA (ORCPT ); Fri, 11 Jun 2021 16:43:00 -0400 Received: from mail-io1-f41.google.com ([209.85.166.41]:42944 "EHLO mail-io1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231264AbhFKUm6 (ORCPT ); Fri, 11 Jun 2021 16:42:58 -0400 Received: by mail-io1-f41.google.com with SMTP id s26so3403554ioe.9 for ; Fri, 11 Jun 2021 13:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P7uaYucC+62klUqk+ruT7sASOO838Q3Fy6yssPZtvh4=; b=KMCAcHJAIMxrgGwUWsIpQ9GXDLNt5lT/NifJxtXW+piGpj/hshXULJfk6G3W/Ce/zI nI+LlP2qDy73Q6Kl8mFbbuzvuIEdchOnRywPShlPUaYjK6KZXxyKEvRQAnwICSDieWVl l1Hns8Xs5uyGYuuVH3+JXO5Z4V0o4luisclY9/O/pkh8WXNujyHC8vWLhRH2JPffbzKZ Tf2+M6anOupoo1HM4OMsUkLyvarGujJIpqKr2YvHZ4rbuTSK7p6g2h6Pc7k8qpl15y8Z xHsqLw9k8/OEVcPjuqC53U8vBbgORFVvjcrxaMuZr7pQtQC5Hwcrv0Gwb7f5QpqHgJPK z4DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P7uaYucC+62klUqk+ruT7sASOO838Q3Fy6yssPZtvh4=; b=KUwI0Q0kZvoCKRMkNrXHw4cXIdCWKTSEG6DWBF9ZNplGUq684f5G1PhPnXa4CusPUS 3WViAoGRgEH8KYBFxf2Dh7knjP0O8ZZc3yjMg8IThHGhko5HYS+cuNVpUQ4I8aHCQf8b O55Fg8AnJMNR5Gxf8qAPTtrrPGhJCil/s20ty+jrHQOb4UoK6sCb67f2Q4SgvJJLyTXn ScDk/csQmiw/E91tBbXm7zySnv0oV+RDdfU0ihlU9mTPux9Pbr/dGGNRo+pjOXwOsMOI D8o+ggfhd9uXyu4dY0zqlLB0WS35ixIepZXae3opbCV6Au7bbMlPoH0ptp/92q3lb/t3 luKw== X-Gm-Message-State: AOAM5329b/Wj2+aO6UpV0jMZrmjx0U8B3Bjz9Own7ovg9PWG7nvXmWAc GYADAIjE5JXyXncdnQ4htmL+uA== X-Google-Smtp-Source: ABdhPJyCVhj8gUrNAlX22r/zn5RovPU3D26T7avfsbxrfpnuFc/GTdhxQlUWZLoeXP0WEkAMhEEXuQ== X-Received: by 2002:a02:354d:: with SMTP id y13mr5524096jae.83.1623443984720; Fri, 11 Jun 2021 13:39:44 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id y9sm3761544ilp.58.2021.06.11.13.39.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 13:39:44 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: leon@kernel.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, aleksander@aleksander.es, ejcaruso@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/3] net: ipa: make endpoint data validation unconditional Date: Fri, 11 Jun 2021 15:39:38 -0500 Message-Id: <20210611203940.3171057-2-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210611203940.3171057-1-elder@linaro.org> References: <20210611203940.3171057-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cost of validating the endpoint configuration data is not all that high, so just do it unconditionally, rather than doing so only when IPA_VALIDATAION is defined. Suggested-by: Leon Romanovsky Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 07a81b73306fe..3520852936ed1 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -75,8 +75,6 @@ struct ipa_status { #define IPA_STATUS_FLAGS1_RT_RULE_ID_FMASK GENMASK(31, 22) #define IPA_STATUS_FLAGS2_TAG_FMASK GENMASK_ULL(63, 16) -#ifdef IPA_VALIDATE - static bool ipa_endpoint_data_valid_one(struct ipa *ipa, u32 count, const struct ipa_gsi_endpoint_data *all_data, const struct ipa_gsi_endpoint_data *data) @@ -225,16 +223,6 @@ static bool ipa_endpoint_data_valid(struct ipa *ipa, u32 count, return true; } -#else /* !IPA_VALIDATE */ - -static bool ipa_endpoint_data_valid(struct ipa *ipa, u32 count, - const struct ipa_gsi_endpoint_data *data) -{ - return true; -} - -#endif /* !IPA_VALIDATE */ - /* Allocate a transaction to use on a non-command endpoint */ static struct gsi_trans *ipa_endpoint_trans_alloc(struct ipa_endpoint *endpoint, u32 tre_count) -- 2.27.0