From: Mark Brown <broonie@kernel.org>
To: "cy_huang(黃啟原)" <cy_huang@richtek.com>
Cc: "axel.lin@ingics.com" <axel.lin@ingics.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: rt6160: Remove vsel_active_low from struct rt6160_priv
Date: Tue, 15 Jun 2021 16:34:24 +0100 [thread overview]
Message-ID: <20210615153424.GJ5149@sirena.org.uk> (raw)
In-Reply-To: <1623770667.4571.4.camel@richtek.com>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
On Tue, Jun 15, 2021 at 03:24:27PM +0000, cy_huang(黃啟原) wrote:
> No, you may misunderstand it.
> If vsel active is high, the normal voltage output register is vselh register,
> and the suspend voltage is vsell register. Else, reverse.
>
> Axel's change will cause the normal/suspend voltage be configured for the same
> register. It's not for our reference usage.
OK, can you please send a patch fixing this and explaining what the
problem was?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-15 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:39 Axel Lin
2021-06-15 15:15 ` Mark Brown
2021-06-15 15:24 ` cy_huang(黃啟原)
2021-06-15 15:34 ` Mark Brown [this message]
2021-06-15 16:04 ` cy_huang(黃啟原)
2021-06-15 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615153424.GJ5149@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=cy_huang@richtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®