From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D65C49361 for ; Wed, 16 Jun 2021 13:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F61A61241 for ; Wed, 16 Jun 2021 13:30:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233289AbhFPNcy (ORCPT ); Wed, 16 Jun 2021 09:32:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:39606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbhFPNcv (ORCPT ); Wed, 16 Jun 2021 09:32:51 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26B0B61166; Wed, 16 Jun 2021 13:30:44 +0000 (UTC) Date: Wed, 16 Jun 2021 09:30:42 -0400 From: Steven Rostedt To: Andy Shevchenko Cc: Randy Dunlap , Chris Down , Linux Kernel Mailing List , Petr Mladek , Jessica Yu , Sergey Senozhatsky , John Ogness , Greg Kroah-Hartman , Johannes Weiner , Kees Cook , Rasmus Villemoes , kernel-team@fb.com Subject: Re: [PATCH v7 1/5] string_helpers: Escape double quotes in escape_special Message-ID: <20210616093042.2036ef2c@gandalf.local.home> In-Reply-To: References: <796701ff-18f9-a637-fca4-808ae36b336f@infradead.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Jun 2021 11:08:18 +0300 Andy Shevchenko wrote: > On Tue, Jun 15, 2021 at 07:05:25PM -0700, Randy Dunlap wrote: > > On 6/15/21 5:00 PM, Chris Down wrote: > > > Andy Shevchenko writes: > > >>> I've checked uses of ESCAPE_SPECIAL and %pE across the codebase, and I'm > > >> > > >> checked the uses > > > > > > Hmm, what's wrong with using the zero article for "checked uses"? I mean, I don't have any strong resistance, but I don't see anything wrong with it either, and it matches how I'd naturally speak. > > > > > > Agreed on the others, though, hopefully they can be massaged in :-) > > > > Ack, I don't see anything wrong with it either. > > I guess you know better than me :-) > > I'm just a mere non-native speaker here to whom it's stylistically harder to > parse without the article. English is weird. It sounds fine to me with and without the "the" article, but I'll say having "the" does make it a little smoother, and probably better for the non-native speaking folks. Technically, I'm a native speaker, but I prefer to say my mother tongue is C. ;-) -- Steve