From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F221C48BE5 for ; Thu, 17 Jun 2021 00:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09315613CB for ; Thu, 17 Jun 2021 00:23:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234984AbhFQAZN (ORCPT ); Wed, 16 Jun 2021 20:25:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:58480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234961AbhFQAZL (ORCPT ); Wed, 16 Jun 2021 20:25:11 -0400 Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13199613B9; Thu, 17 Jun 2021 00:23:03 +0000 (UTC) Date: Wed, 16 Jun 2021 20:23:02 -0400 From: Steven Rostedt To: Mark-PK Tsai Cc: , , , , , , , Subject: Re: [PATCH v4] recordmcount: Correct st_shndx handling Message-ID: <20210616202302.18522133@rorschach.local.home> In-Reply-To: <20210616120227.6fc005c3@gandalf.local.home> References: <20210616154126.2794-1-mark-pk.tsai@mediatek.com> <20210616120227.6fc005c3@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Jun 2021 12:02:27 -0400 Steven Rostedt wrote: > On Wed, 16 Jun 2021 23:41:26 +0800 > Mark-PK Tsai wrote: > > > From: Peter Zijlstra > > > > One should only use st_shndx when >SHN_UNDEF and > SHN_XINDEX, then use .symtab_shndx. Otherwise use 0. > > > > This handles the case: st_shndx >= SHN_LORESERVE && st_shndx != SHN_XINDEX. > > > > Reported-by: Mark-PK Tsai > > Signed-off-by: Peter Zijlstra (Intel) > > Tested-by: Mark-PK Tsai > > [handle endianness of sym->st_shndx] > > Signed-off-by: Mark-PK Tsai > > --- > > Thanks, I pulled this in and started the testing. > It passed my normal tests. I'll run my cross compile test, and I just pushed it to linux-next. I'll wait a few days before I push it to Linus. -- Steve