From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Stephen Boyd <swboyd@chromium.org>,
Alexander Potapenko <glider@google.com>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: [PATCH next v4 0/2] introduce printk cpu lock
Date: Thu, 17 Jun 2021 11:56:49 +0206 [thread overview]
Message-ID: <20210617095051.4808-1-john.ogness@linutronix.de> (raw)
Hello,
While working on removing the safe buffers for printk [0] we
stumbled on a cpu-reentrant spinning lock used by dump_stack(). This
type of lock (dubbed a cpu lock) will cause deadlock risks once we
introduce atomic consoles because atomic consoles also need such a
lock.
Although we are not yet ready to introduce atomic consoles, this is
an appropriate time to provide an official cpu lock to be used for
all things relating to printk (including the atomic consoles, once
they are introduced).
An example of cpu lock usage for atomic consoles can be found in the
PREEMPT_RT tree, such as the serial8250 implementation [1] of an
atomic console. (In PREEMPT_RT the printk cpu lock function was
named console_atomic_lock/_unlock.)
This series is against next-20210616.
v3 can be found here [2].
Changes since v3:
- Change @printk_cpulock_nested from a boolean to an atomic counter
in order to track multiple levels of nesting.
- Correctly move over the original dump_stack() semantics by using
atomic_set() to unlock.
- Move commit message note about disabling interrupts to the first
patch.
John Ogness
[0] https://lore.kernel.org/lkml/YGW63%2FelFr%2FgYW1u@alley
[1] https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/drivers/tty/serial?h=v5.12-rc3-rt3&id=1aaca59df62710647243a3574fc27d93c2bd0e6c
[2] https://lore.kernel.org/lkml/20210615174947.32057-1-john.ogness@linutronix.de
John Ogness (2):
lib/dump_stack: move cpu lock to printk.c
printk: fix cpu lock ordering
include/linux/printk.h | 41 +++++++++++++++
kernel/printk/printk.c | 116 +++++++++++++++++++++++++++++++++++++++++
lib/dump_stack.c | 38 +-------------
3 files changed, 159 insertions(+), 36 deletions(-)
--
2.20.1
next reply other threads:[~2021-06-17 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 9:50 John Ogness [this message]
2021-06-17 9:50 ` [PATCH next v4 1/2] lib/dump_stack: move cpu lock to printk.c John Ogness
2021-06-17 13:32 ` Steven Rostedt
2021-06-18 14:47 ` Petr Mladek
2021-06-18 16:25 ` Steven Rostedt
2021-06-19 0:22 ` John Ogness
2021-06-18 14:55 ` John Ogness
2021-06-18 16:31 ` Steven Rostedt
2021-06-17 9:50 ` [PATCH next v4 2/2] printk: fix cpu lock ordering John Ogness
2021-06-17 11:23 ` [PATCH next v4 0/2] introduce printk cpu lock Petr Mladek
2021-06-17 11:28 ` Stephen Rothwell
2021-06-17 11:39 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617095051.4808-1-john.ogness@linutronix.de \
--to=john.ogness@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sfr@canb.auug.org.au \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®