From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7DBC48BE5 for ; Sat, 19 Jun 2021 07:29:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E381661159 for ; Sat, 19 Jun 2021 07:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233840AbhFSHbJ (ORCPT ); Sat, 19 Jun 2021 03:31:09 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:56425 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232445AbhFSHbH (ORCPT ); Sat, 19 Jun 2021 03:31:07 -0400 X-UUID: 89e90070255a46ffbeaf675968f97a16-20210619 X-UUID: 89e90070255a46ffbeaf675968f97a16-20210619 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 472223609; Sat, 19 Jun 2021 15:28:55 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 19 Jun 2021 15:28:53 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 19 Jun 2021 15:28:53 +0800 From: Lecopzer Chen To: CC: , , , , Subject: Re: [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module Date: Sat, 19 Jun 2021 15:28:53 +0800 Message-ID: <20210619072853.25882-1-lecopzer.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20210618162334.GA31513@gofer.mess.org> References: <20210618162334.GA31513@gofer.mess.org> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, Jun 08, 2021 at 06:14:51PM +0800, Lecopzer Chen wrote: > > The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and > > default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m > > since the type of MEDIA_DIGITAL_TV_SUPPORT is bool. > > First of all, the distributions carrry dvb_core as a module, so clearly > it possible to set DVB_CORE=m. > > As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m. > > So it is possible. Thanks for review. After checking, It does change DVB_CORE=m if MEDIA_SUPPORT=m. We had MEDIA_SUPPORT=y, thus misunderstood by 'default MEDIA_DIGITAL_TV_SUPPORT'. Thanks again for figuring out this. -Lecopzer