From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F336C49361 for ; Sat, 19 Jun 2021 15:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FEAE61264 for ; Sat, 19 Jun 2021 15:17:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234580AbhFSPT5 (ORCPT ); Sat, 19 Jun 2021 11:19:57 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:63426 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbhFSPT4 (ORCPT ); Sat, 19 Jun 2021 11:19:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624115865; h=Content-Transfer-Encoding: MIME-Version: Message-Id: Date: Subject: Cc: To: From: Sender; bh=ZNkErgOvLQ2pXTqJXZtvrUoHzxerpSKdE7RL22hJuu0=; b=amhD2WrSTCUou7aqlAUQGJhVDpkzAUXEiHBSdJOtW8jktn33biKgHqNR9funRsAciz4N178C gjhHi4uZmYM3NzzdgwbuGV8J9SjiHxbmo4I1M3/uqJ5ms+Vq7S4tSugpsUPfoAIjzVbQC48V QiBh94zOewyCxWNUibajELa1Zvk= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 60ce0a92ea2aacd729a8c825 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 19 Jun 2021 15:17:38 GMT Sender: linyyuan=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F1053C433D3; Sat, 19 Jun 2021 15:17:37 +0000 (UTC) Received: from localhost.localdomain (unknown [101.87.142.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: linyyuan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 784EDC4338A; Sat, 19 Jun 2021 15:17:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 784EDC4338A Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=linyyuan@codeaurora.org From: Linyu Yuan To: Felipe Balbi , Thinh Nguyen , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jack Pham , Linyu Yuan Subject: [PATCH 1/2] usb: udc: core: hide struct usb_gadget_driver to gadget driver Date: Sat, 19 Jun 2021 23:17:14 +0800 Message-Id: <20210619151714.51652-1-linyyuan@codeaurora.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org currently most gadget driver have a pointer to save struct usb_gadget_driver from upper layer, it allow upper layer set and unset of the pointer. there is race that upper layer unset the pointer first, but gadget driver use the pointer later, and it cause system crash due to NULL pointer access. Signed-off-by: Linyu Yuan --- drivers/usb/gadget/udc/core.c | 47 ++++++++++++++++++++++++++++++++++- include/linux/usb/gadget.h | 6 +++++ 2 files changed, 52 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index b7f0b1ebaaa8..44af6ff281d3 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1052,6 +1052,45 @@ void usb_udc_vbus_handler(struct usb_gadget *gadget, bool status) } EXPORT_SYMBOL_GPL(usb_udc_vbus_handler); +void usb_gadget_udc_disconnect(struct usb_gadget *gadget) +{ + struct usb_udc *udc = gadget->udc; + + if (udc && udc->driver && udc->driver->disconnect) + udc->driver->disconnect(gadget); +} +EXPORT_SYMBOL_GPL(usb_gadget_udc_disconnect); + +void usb_gadget_udc_suspend(struct usb_gadget *gadget) +{ + struct usb_udc *udc = gadget->udc; + + if (udc && udc->driver && udc->driver->suspend) + udc->driver->suspend(gadget); +} +EXPORT_SYMBOL_GPL(usb_gadget_udc_suspend); + +void usb_gadget_udc_resume(struct usb_gadget *gadget) +{ + struct usb_udc *udc = gadget->udc; + + if (udc && udc->driver && udc->driver->resume) + udc->driver->resume(gadget); +} +EXPORT_SYMBOL_GPL(usb_gadget_udc_resume); + +int usb_gadget_udc_setup(struct usb_gadget *gadget, + const struct usb_ctrlrequest *ctrl) +{ + struct usb_udc *udc = gadget->udc; + + if (udc && udc->driver) + return udc->driver->setup(gadget, ctrl); + + return -EINVAL; +} +EXPORT_SYMBOL_GPL(usb_gadget_udc_setup); + /** * usb_gadget_udc_reset - notifies the udc core that bus reset occurs * @gadget: The gadget which bus reset occurs @@ -1064,7 +1103,13 @@ EXPORT_SYMBOL_GPL(usb_udc_vbus_handler); void usb_gadget_udc_reset(struct usb_gadget *gadget, struct usb_gadget_driver *driver) { - driver->reset(gadget); + struct usb_udc *udc = gadget->udc; + + if (driver) + driver->reset(gadget); + else if (udc && udc->driver) + udc->driver->reset(gadget); + usb_gadget_set_state(gadget, USB_STATE_DEFAULT); } EXPORT_SYMBOL_GPL(usb_gadget_udc_reset); diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index 75c7538e350a..85f4c87ba5b3 100644 --- a/include/linux/usb/gadget.h +++ b/include/linux/usb/gadget.h @@ -881,6 +881,12 @@ extern void usb_gadget_set_state(struct usb_gadget *gadget, /*-------------------------------------------------------------------------*/ +extern void usb_gadget_udc_disconnect(struct usb_gadget *gadget); +extern void usb_gadget_udc_suspend(struct usb_gadget *gadget); +extern void usb_gadget_udc_resume(struct usb_gadget *gadget); +extern int usb_gadget_udc_setup(struct usb_gadget *gadget, + const struct usb_ctrlrequest *ctrl); + /* utility to tell udc core that the bus reset occurs */ extern void usb_gadget_udc_reset(struct usb_gadget *gadget, struct usb_gadget_driver *driver); -- 2.25.1