From: Jinchao Wang <wjc@cdjrlc.com>
To: rjw@rjwysocki.net
Cc: linux-kernel@vger.kernel.org, wjc@cdjrlc.com, linux-pm@vger.kernel.org
Subject: [PATCH] powercap: Replace symbolic permissions with octal permissions
Date: Thu, 24 Jun 2021 16:44:03 +0800 [thread overview]
Message-ID: <20210624084403.1163-1-wjc@cdjrlc.com> (raw)
Resolve following checkpatch issue,
Replace symbolic permissions with octal permissions
Signed-off-by: Jinchao Wang <wjc@cdjrlc.com>
---
drivers/powercap/powercap_sys.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
index f0654a932b37..e706548c59bb 100644
--- a/drivers/powercap/powercap_sys.c
+++ b/drivers/powercap/powercap_sys.c
@@ -223,46 +223,46 @@ static int seed_constraint_attributes(void)
for (i = 0; i < MAX_CONSTRAINTS_PER_ZONE; ++i) {
ret = create_constraint_attribute(i, "power_limit_uw",
- S_IWUSR | S_IRUGO,
+ 0644,
&constraint_attrs[i].power_limit_attr,
show_constraint_power_limit_uw,
store_constraint_power_limit_uw);
if (ret)
goto err_alloc;
ret = create_constraint_attribute(i, "time_window_us",
- S_IWUSR | S_IRUGO,
+ 0644,
&constraint_attrs[i].time_window_attr,
show_constraint_time_window_us,
store_constraint_time_window_us);
if (ret)
goto err_alloc;
- ret = create_constraint_attribute(i, "name", S_IRUGO,
+ ret = create_constraint_attribute(i, "name", 0444,
&constraint_attrs[i].name_attr,
show_constraint_name,
NULL);
if (ret)
goto err_alloc;
- ret = create_constraint_attribute(i, "max_power_uw", S_IRUGO,
+ ret = create_constraint_attribute(i, "max_power_uw", 0444,
&constraint_attrs[i].max_power_attr,
show_constraint_max_power_uw,
NULL);
if (ret)
goto err_alloc;
- ret = create_constraint_attribute(i, "min_power_uw", S_IRUGO,
+ ret = create_constraint_attribute(i, "min_power_uw", 0444,
&constraint_attrs[i].min_power_attr,
show_constraint_min_power_uw,
NULL);
if (ret)
goto err_alloc;
ret = create_constraint_attribute(i, "max_time_window_us",
- S_IRUGO,
+ 0444,
&constraint_attrs[i].max_time_window_attr,
show_constraint_max_time_window_us,
NULL);
if (ret)
goto err_alloc;
ret = create_constraint_attribute(i, "min_time_window_us",
- S_IRUGO,
+ 0444,
&constraint_attrs[i].min_time_window_attr,
show_constraint_min_time_window_us,
NULL);
@@ -366,9 +366,9 @@ static void create_power_zone_common_attributes(
&dev_attr_max_energy_range_uj.attr;
if (power_zone->ops->get_energy_uj) {
if (power_zone->ops->reset_energy_uj)
- dev_attr_energy_uj.attr.mode = S_IWUSR | S_IRUSR;
+ dev_attr_energy_uj.attr.mode = 0600;
else
- dev_attr_energy_uj.attr.mode = S_IRUSR;
+ dev_attr_energy_uj.attr.mode = 0400;
power_zone->zone_dev_attrs[count++] =
&dev_attr_energy_uj.attr;
}
--
2.31.1
next reply other threads:[~2021-06-24 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 8:44 Jinchao Wang [this message]
2021-06-30 17:41 ` Rafael J. Wysocki
2021-06-30 18:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624084403.1163-1-wjc@cdjrlc.com \
--to=wjc@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®