From: Steven Rostedt <rostedt@goodmis.org>
To: Yun Zhou <yun.zhou@windriver.com>
Cc: linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com, ying.xue@windriver.com, "Li,
Zhiquan" <Zhiquan.Li@windriver.com>
Subject: Re: [PATCH] seq_buf: let seq_buf_putmem_hex support len larger than 8
Date: Fri, 25 Jun 2021 09:27:33 -0400 [thread overview]
Message-ID: <20210625092733.63bde998@oasis.local.home> (raw)
In-Reply-To: <06010fbf-1d46-3313-1545-b75c42f19935@windriver.com>
On Fri, 25 Jun 2021 15:28:25 +0800
Yun Zhou <yun.zhou@windriver.com> wrote:
> Hi Mr Steven,
>
> I found that you had ever wanted to enhance trace_seq_putmem_hex() to
>
> allow any size input(6d2289f3faa71dcc). Great minds think alike. Your
>
> enhancement will let the function more robust, I think it is very advisable.
>
> Now we only need modify two lines to solve a little flaw, and to let it
>
> more more robust.
You are still solving two bugs with one patch, which is considered a no-no.
One bug fix needs to go back to the beginning. If you want to add the
other update, then it could be labeled a fix to that commit. Either
way, it requires two patches.
-- Steve
prev parent reply other threads:[~2021-06-25 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 13:16 Yun Zhou
2021-06-24 14:54 ` Steven Rostedt
2021-06-25 3:41 ` Yun Zhou
2021-06-25 4:08 ` Steven Rostedt
2021-06-25 6:25 ` Yun Zhou
[not found] ` <06010fbf-1d46-3313-1545-b75c42f19935@windriver.com>
2021-06-25 13:27 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625092733.63bde998@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=Zhiquan.Li@windriver.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.xue@windriver.com \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®