From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95ED0C48BC2 for ; Fri, 25 Jun 2021 19:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F6B461981 for ; Fri, 25 Jun 2021 19:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230002AbhFYTyk (ORCPT ); Fri, 25 Jun 2021 15:54:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34987 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbhFYTye (ORCPT ); Fri, 25 Jun 2021 15:54:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624650732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zmCqJFhviJpySBAFzJy5r5IMKlvduxQc5V68S9Vd+94=; b=NSgRG3A5OUP4eJmALrEns2w/TMVNvOlEJoWjjEBoN+nthgPV3IOCSWx1jIfxchVbLrHlES 0nSWDzR0VcOQ72xqyii8nkOGsE1U0MbJ19HKY90JKhsVGPnrhf2LhHr6NaC8rajI7eHg8e efLU7kkRPZ92Gr4fouab1brfur5hw14= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-IgQm4fVANHKjDlkyYVwyHw-1; Fri, 25 Jun 2021 15:52:11 -0400 X-MC-Unique: IgQm4fVANHKjDlkyYVwyHw-1 Received: by mail-oi1-f198.google.com with SMTP id a29-20020a544e1d0000b02901eef9e4a58cso6544973oiy.3 for ; Fri, 25 Jun 2021 12:52:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zmCqJFhviJpySBAFzJy5r5IMKlvduxQc5V68S9Vd+94=; b=iDUkSajVFPlHVA4q/pfJCqc39ErkHUG7tEGpmiKyhTXx6V/+glIur+JbegDiOJfl80 VuTxE1X4Vy4hGPF/o1gew0ilqTxVUIESoVcfEsf0R+BnPAzBDsRQRdEOPyOnbR75cPLi 1pe2b4prD/B6MXhgNCtQrefe9GTB2p4WWjseBIJXfsuoOQpGClpEPstY4GM2u/YlMSpR 21upWC/LKui6pA+wWAfI2yf7DOve8QmZjUwIGCwzyzgFmrR5YhjriRiAXsItxUgsOcEq AH+AVZ+YAuyuJDXRDU9BvvvPEnSkycGmCp8+nZm2ZTxQ7neqVlkq1ODZQMnNt4OBZZAF Tv3Q== X-Gm-Message-State: AOAM530LrsBM7KJmU7gOMGl/D/Sk1/kcROwT5sJck0kphk4u82N86P6I zOEVU9Bw2zbzR62kx7zjaRsvhJLqqjKycACxwo90Y7DQQco7rLJUbRnRch0woFwoONCpcnN2H4L z9vomuPmTQhGPPuKMcNhLbPok X-Received: by 2002:a9d:6f10:: with SMTP id n16mr11442609otq.165.1624650730699; Fri, 25 Jun 2021 12:52:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyrgSs3HSrKX/eB4qtz68tFE9zA+wja/zPnCCLulswoCm4r95WfyEGRwhxQDpXEZZe+Gx01A== X-Received: by 2002:a9d:6f10:: with SMTP id n16mr11442598otq.165.1624650730534; Fri, 25 Jun 2021 12:52:10 -0700 (PDT) Received: from localhost.localdomain.com (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o25sm1535446ood.20.2021.06.25.12.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 12:52:10 -0700 (PDT) From: trix@redhat.com To: hao.wu@intel.com, mdf@kernel.org, michal.simek@xilinx.com Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tom Rix Subject: [PATCH v4 3/7] fpga-mgr: wrap the write() op Date: Fri, 25 Jun 2021 12:51:44 -0700 Message-Id: <20210625195148.837230-5-trix@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210625195148.837230-1-trix@redhat.com> References: <20210625195148.837230-1-trix@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix An FPGA manager should not be required to provide a write function. Move the op check to the wrapper. Default to -EOPNOTSUP so its users will fail gracefully. Signed-off-by: Tom Rix --- drivers/fpga/fpga-mgr.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index 05a69ab3ecb9e..8d5536d748081 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -25,6 +25,13 @@ struct fpga_mgr_devres { struct fpga_manager *mgr; }; +static inline int fpga_mgr_write(struct fpga_manager *mgr, const char *buf, size_t count) +{ + if (mgr->mops->write) + return mgr->mops->write(mgr, buf, count); + return -EOPNOTSUPP; +} + /* * After all the FPGA image has been written, do the device specific steps to * finish and set the FPGA into operating mode. @@ -204,7 +211,7 @@ static int fpga_mgr_buf_load_sg(struct fpga_manager *mgr, sg_miter_start(&miter, sgt->sgl, sgt->nents, SG_MITER_FROM_SG); while (sg_miter_next(&miter)) { - ret = mgr->mops->write(mgr, miter.addr, miter.length); + ret = fpga_mgr_write(mgr, miter.addr, miter.length); if (ret) break; } @@ -234,7 +241,7 @@ static int fpga_mgr_buf_load_mapped(struct fpga_manager *mgr, * Write the FPGA image to the FPGA. */ mgr->state = FPGA_MGR_STATE_WRITE; - ret = mgr->mops->write(mgr, buf, count); + ret = fpga_mgr_write(mgr, buf, count); if (ret) { dev_err(&mgr->dev, "Error while writing image data to FPGA\n"); mgr->state = FPGA_MGR_STATE_WRITE_ERR; @@ -578,9 +585,7 @@ struct fpga_manager *fpga_mgr_create(struct device *parent, const char *name, struct fpga_manager *mgr; int id, ret; - if (!mops || !mops->state || - (!mops->write && !mops->write_sg) || - (mops->write && mops->write_sg)) { + if (!mops || !mops->state) { dev_err(parent, "Attempt to register without fpga_manager_ops\n"); return NULL; } -- 2.26.3