From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C76C11F65 for ; Mon, 28 Jun 2021 23:00:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9409261CFA for ; Mon, 28 Jun 2021 23:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236124AbhF1XCj (ORCPT ); Mon, 28 Jun 2021 19:02:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:38624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235313AbhF1XCb (ORCPT ); Mon, 28 Jun 2021 19:02:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 24A7461CF8; Mon, 28 Jun 2021 23:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1624921205; bh=ZsWXc9FKF9jThbjc7um9yI6tcNaF+KHjq8t5fFUWmrc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l1Zz2/tgvo1jyws/qAAFhigF8Ji8mVZa67ZBwc7L4Z/eMFlUg6ea9eZPnW14/lGO/ T40NIIeTtGjzYibo4b1ahhUd+nquuolDPjU/RqK60dldHkZHScuun1Wm8ptLYW9hyk xeb2ycRQWVmPW/4xxPSW6iZbPhbacFkO4KvTFq28= Date: Mon, 28 Jun 2021 16:00:04 -0700 From: Andrew Morton To: Uladzislau Rezki Cc: Christoph Hellwig , Mel Gorman , linux-mm@kvack.org, LKML , Matthew Wilcox , Nicholas Piggin , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH 2/3] mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node() Message-Id: <20210628160004.ad39038af33e4be17df0d7f6@linux-foundation.org> In-Reply-To: <20210519210750.GA5615@pc638.lan> References: <20210516202056.2120-1-urezki@gmail.com> <20210516202056.2120-3-urezki@gmail.com> <20210519143900.GA2262@pc638.lan> <20210519155630.GD3672@suse.de> <20210519195214.GA2343@pc638.lan> <20210519210750.GA5615@pc638.lan> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 May 2021 23:07:50 +0200 Uladzislau Rezki wrote: > > Basically a single-page allocator is more permissive so it is a higher > > chance to success. Therefore a fallback to it makes sense. > > > Hello, Christoph. > > See below the patch. Does it sound good for you? It is about moving > page allocation part into separate function: Please just send over a patch which addresses this and Christoph's other review comments. I don't think the discussion with Mel against this patch identified any needed changes, so I'll send this series to Linus.