From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: zhanglianjie <zhanglianjie@uniontech.com>
Cc: jiaxun.yang@flygoat.com, chenhuacai@kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm: Fix the problem of mips architecture Oops
Date: Tue, 29 Jun 2021 10:32:23 +0200 [thread overview]
Message-ID: <20210629083223.GB4650@alpha.franken.de> (raw)
In-Reply-To: <20210628091105.27641-1-zhanglianjie@uniontech.com>
On Mon, Jun 28, 2021 at 05:11:05PM +0800, zhanglianjie wrote:
> The cause of the problem is as follows:
> 1. when cat /sys/devices/system/memory/memory0/valid_zones,
> test_pages_in_a_zone() will be called.
> 2. test_pages_in_a_zone() finds the zone according to stat_pfn = 0.
> The smallest pfn of the numa node in the mips architecture is 128,
> and the page corresponding to the previous 0~127 pfn is not
> initialized (page->flags is 0xFFFFFFFF)
> 3. The nid and zonenum obtained using page_zone(pfn_to_page(0)) are out
> of bounds in the corresponding array,
> &NODE_DATA(page_to_nid(page))->node_zones[page_zonenum(page)],
> access to the out-of-bounds zone member variables appear abnormal,
> resulting in Oops.
> Therefore, it is necessary to keep the page between 0 and the minimum
> pfn to prevent Oops from appearing.
>
> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
> ---
> arch/mips/loongson64/numa.c | 3 +++
> 1 file changed, 3 insertions(+)
applied to mips-next (with subject changed to reflect what patch does).
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-06-29 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 9:11 zhanglianjie
2021-06-29 8:32 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629083223.GB4650@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=zhanglianjie@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®