From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38727C11F66 for ; Tue, 29 Jun 2021 08:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CCE861DC1 for ; Tue, 29 Jun 2021 08:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232666AbhF2Izq (ORCPT ); Tue, 29 Jun 2021 04:55:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232653AbhF2Izo (ORCPT ); Tue, 29 Jun 2021 04:55:44 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55843C061574 for ; Tue, 29 Jun 2021 01:53:15 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id g6-20020a17090adac6b029015d1a9a6f1aso1545653pjx.1 for ; Tue, 29 Jun 2021 01:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Y/8aWcR8pQLRr1AneyecLvILPcZP/SywuwqtFiKRs6o=; b=UERVdQrpA6QxI7RQYA+eUhOfbgXgeUFYb4pvURcjwQKvNlRQqHAOYqkWee5zs+Xjb0 Ah3t28sJQF+zhkVQHRqUV46YTiZXGBh15MtEwUIevK9C7jHP7Fn7YYpts7mxMjBYXvfV 47iOj3Tl6L2SOmEYsEKhu1xRsUleykMhGR2fkj71nvNEvo29dZejYi93pRIysLFg/Jyj JIwu/CkRn40298AVPZw0CFNk+2U+cYskRpjwI/yVZ8wTDOqXyUmLMtHYRw69DrGY1b7o BrSUColfv2WDuJLrTcLbkUPwpk6iOu0/QE8q5I/rcsxj598vsuZMvfGGMrfhnqAJGbzj noXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Y/8aWcR8pQLRr1AneyecLvILPcZP/SywuwqtFiKRs6o=; b=H93aH+HO6wGmrNjYT13qrPP2f3SHKcy7lER0bBAQBP5B6fdvgFMen8jOl1899vTBUf TOhAoZnfGOkgntA8bgekKaI8nCyARR7GOSyFS1PgR7YG/GiMr9S6kTchkaT9BoCwhltN GGRA/DL1preqXxGAfJHupbbkF3ruTcoIxkQtM55XHmhj9T9kGyBObzvD5ebOmACjWsuf +1/wb72URTcmYWQuuhLXcWgWeEEhIeRwtkWDuvVFVG03wwzpGbZuVFHPFPVfjm+Y04Jl m6PJphEQf7/04Ft+KUOiW8wJ0LDmffIz4DS9HCdVTCy3rbBvk7xeeOHlBLucWtc6aePx 2JLQ== X-Gm-Message-State: AOAM533FLRR8ISYwrl5G/4bQW9fzkGKqmER3NRGIAZxuMcb2GU6kBLcg ZmPeyhFTs/3Ycwi46MHsVNmlvA== X-Google-Smtp-Source: ABdhPJwo1gpUzWaxumdXxHpJ6qsqw7SXNoTKDhbjUPtSfTPJXEB307kK2Bp7DWMmed5a8furb5U99g== X-Received: by 2002:a17:90a:5907:: with SMTP id k7mr33269795pji.196.1624956794956; Tue, 29 Jun 2021 01:53:14 -0700 (PDT) Received: from localhost ([136.185.134.182]) by smtp.gmail.com with ESMTPSA id i188sm6191585pfe.30.2021.06.29.01.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 01:53:14 -0700 (PDT) Date: Tue, 29 Jun 2021 14:23:12 +0530 From: Viresh Kumar To: Ionela Voinescu Cc: Rafael Wysocki , Sudeep Holla , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , linux-pm@vger.kernel.org, Qian Cai , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 4/4] cpufreq: CPPC: Add support for frequency invariance Message-ID: <20210629085312.j6f4e4b6vuezsqvm@vireshk-i7> References: <20210624094812.GA6095@arm.com> <20210624130418.poiy4ph66mbv3y67@vireshk-i7> <20210625085454.GA15540@arm.com> <20210625165418.shi3gkebumqllxma@vireshk-i7> <20210628104929.GA29595@arm.com> <20210629043244.xkjat5dqqjaixkii@vireshk-i7> <20210629084737.GB2425@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210629084737.GB2425@arm.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-06-21, 09:47, Ionela Voinescu wrote: > Okay, makes sense. I have not seen this code actually do anything wrong > so far, and the issues I see on ThunderX2 point more to misbehaving > counters for this purpose. This being said, I would have probably > preferred for this feature to be disabled by default, until we've tested > more, but that won't give the chance to anyone else to test. > > Thanks! > > Reviewed-by: Ionela Voinescu Thanks for understanding Ionela. -- viresh