From: Luis Henriques <lhenriques@suse.de>
To: Jeff Layton <jlayton@kernel.org>, Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Henriques <lhenriques@suse.de>
Subject: [RFC PATCH v2 0/2] ceph_check_delayed_caps() softlockup
Date: Tue, 29 Jun 2021 10:47:47 +0100 [thread overview]
Message-ID: <20210629094749.25253-1-lhenriques@suse.de> (raw)
This is an attempt to fix the softlock on the delayed_work workqueue. As
stated in 0002 patch:
Function ceph_check_delayed_caps() is called from the mdsc->delayed_work
workqueue and it can be kept looping for quite some time if caps keep being
added back to the mdsc->cap_delay_list. This may result in the watchdog
tainting the kernel with the softlockup flag.
v2 of this fix modifies the approach by time-bounding the loop in this
function, so that any caps added to the list *after* the loop starts will
be postponed to the next wq run.
An extra change in 0001 (suggested by Jeff) allows scheduling runs for
periods smaller than the default (5 secs) period. This way,
delayed_work() can have the next run scheduled for the next list element
ci->i_hold_caps_max instead of 5 secs.
This patchset should fix the issue reported here [1], although a quick
search for "ceph_check_delayed_caps" in the tracker returns a few more
bugs, possibly duplicates.
[1] https://tracker.ceph.com/issues/46284
Luis Henriques (2):
ceph: allow schedule_delayed() callers to set delay for workqueue
ceph: reduce contention in ceph_check_delayed_caps()
fs/ceph/caps.c | 17 ++++++++++++++++-
fs/ceph/mds_client.c | 24 +++++++++++++++---------
fs/ceph/super.h | 2 +-
3 files changed, 32 insertions(+), 11 deletions(-)
next reply other threads:[~2021-06-29 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 9:47 Luis Henriques [this message]
2021-06-29 9:47 ` [RFC PATCH v2 1/2] ceph: allow schedule_delayed() callers to set delay for workqueue Luis Henriques
2021-06-29 10:14 ` Ilya Dryomov
2021-06-29 10:53 ` Luis Henriques
2021-06-29 9:47 ` [RFC PATCH v2 2/2] ceph: reduce contention in ceph_check_delayed_caps() Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629094749.25253-1-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®