From: Mark Brown <broonie@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Tony Lindgren <tony@atomide.com>,
Liam Girdwood <lgirdwood@gmail.com>, Nishanth Menon <nm@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
letux-kernel@openphoenux.org, kernel@pyra-handheld.com
Subject: Re: [PATCH] regulator: palmas: set supply_name after registering the regulator
Date: Tue, 29 Jun 2021 16:59:22 +0100 [thread overview]
Message-ID: <20210629155922.GD4613@sirena.org.uk> (raw)
In-Reply-To: <4ed67090bc048442567931ede8f1298a0b312b28.1624980242.git.hns@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Tue, Jun 29, 2021 at 05:24:03PM +0200, H. Nikolaus Schaller wrote:
> Commit 98e48cd9283d ("regulator: core: resolve supply for boot-on/always-on regulators")
>
> introduced a new rule which makes Palmas regulator registration fail:
>
> [ 5.407712] ldo1: supplied by vsys_cobra
> [ 5.412748] ldo2: supplied by vsys_cobra
> [ 5.417603] palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmas@48:palmas_pmic regulator
>
> This seems to block additions initializations and finally the
> Pyra-Handheld hangs when trying to access MMC because there is
> no mmc-supply available.
What is that rule and how is this patch intended to ensure that Palmas
meets it? As covered in submitting-patches.rst your changelog should
explain this so that in review we can verify that this is a good fix.
The change itself looks worrying like it just shuts the error up and
could cause problems for other systems.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-29 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 15:24 H. Nikolaus Schaller
2021-06-29 15:59 ` Mark Brown [this message]
2021-06-29 18:34 ` H. Nikolaus Schaller
2021-06-29 18:56 ` Mark Brown
2021-06-29 20:21 ` H. Nikolaus Schaller
2021-06-29 20:26 ` Graeme Gregory
2021-06-30 12:13 ` Mark Brown
2021-06-30 12:29 ` H. Nikolaus Schaller
2021-06-30 13:04 ` Mark Brown
2021-06-30 14:43 ` H. Nikolaus Schaller
2021-06-30 16:45 ` Mark Brown
2021-06-30 17:17 ` H. Nikolaus Schaller
2021-06-30 20:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629155922.GD4613@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®