From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0F066C11F65
	for <linux-kernel@archiver.kernel.org>; Wed, 30 Jun 2021 04:23:20 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id DFA0861CD5
	for <linux-kernel@archiver.kernel.org>; Wed, 30 Jun 2021 04:23:19 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233215AbhF3EZq (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 30 Jun 2021 00:25:46 -0400
Received: from mail.kernel.org ([198.145.29.99]:50752 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230200AbhF3EZn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Jun 2021 00:25:43 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0089661D28;
        Wed, 30 Jun 2021 04:23:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1625026995;
        bh=kfVIrUp5BJMPXgGi+SKitP2xMU5X2s71OIZL89q3Jik=;
        h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From;
        b=kgwc52ch1Jj2pGPsqlFcsAZUODYdbMVPDP66X4tyfZpqHLKfKtPPs7/reb9Rjb8T3
         OcS8P9e59CEDzDFpxzejRkxYBucWRPsSYXUrO2uqcEt0JoSGKFtYxMq4q3+dsC5qXc
         GksYOcvBuUmiLbrD0YzwlGNUdllKkD/9eoC/BANZ5/a1sWv0a2FicTnSGjC6iH+BWG
         zpSWfA8eu9FEAEQ6BjqGvKU767A//2N6HoVZZOUbMV4KdSmhDfdh6YhsmisqG/lT2t
         PBy0jCnIoKb24zlXJWHbVSK9pgypQ1toEtWosXoBqiMDPSELQehz4AZu4BK8lXDM+M
         V52flCkQ18OGw==
Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000)
        id DBD8F5C02AB; Tue, 29 Jun 2021 21:23:14 -0700 (PDT)
Date:   Tue, 29 Jun 2021 21:23:14 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     liu.song11@zte.com.cn
Cc:     fishland@aliyun.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Remove unnecessary updates to ret in rcu_gp_fqs_loop
Message-ID: <20210630042314.GU4397@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20210629174408.GS4397@paulmck-ThinkPad-P17-Gen-1>
 <202106301122531910761@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202106301122531910761@zte.com.cn>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 30, 2021 at 11:22:53AM +0800, liu.song11@zte.com.cn wrote:
> > rcu: Remove useless "ret" update in rcu_gp_fqs_loop()
> >      
> >     Within rcu_gp_fqs_loop(), the "ret" local variable is set to the
> >     return value from swait_event_idle_timeout_exclusive(), but "ret" is
> >     unconditionally overwritten later in the code.  This commit therefore
> >     removes this useless assignment.
> 
> The revised commit log is exactly what I want to express, it is perfect.

Thank you for looking it over!

							Thanx, Paul