From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33351C11F68 for ; Wed, 30 Jun 2021 12:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EAB1613E0 for ; Wed, 30 Jun 2021 12:54:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234767AbhF3M45 (ORCPT ); Wed, 30 Jun 2021 08:56:57 -0400 Received: from elvis.franken.de ([193.175.24.41]:59648 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234481AbhF3M44 (ORCPT ); Wed, 30 Jun 2021 08:56:56 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lyZjT-0007Hs-01; Wed, 30 Jun 2021 14:54:23 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D80C0C0755; Wed, 30 Jun 2021 14:42:14 +0200 (CEST) Date: Wed, 30 Jun 2021 14:42:14 +0200 From: Thomas Bogendoerfer To: Wei Li Cc: Thomas Gleixner , Andrew Morton , Paul Cercueil , Daniel Silsby , Paul Burton , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, huawei.libin@huawei.com Subject: Re: [PATCH RESEND] MIPS: Fix PKMAP with 32-bit MIPS huge page support Message-ID: <20210630124214.GB7139@alpha.franken.de> References: <20210629141420.1790569-1-liwei391@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210629141420.1790569-1-liwei391@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 29, 2021 at 10:14:20PM +0800, Wei Li wrote: > When 32-bit MIPS huge page support is enabled, we halve the number of > pointers a PTE page holds, making its last half go to waste. > Correspondingly, we should halve the number of kmap entries, as we just > initialized only a single pte table for that in pagetable_init(). > > Fixes: 35476311e529 ("MIPS: Add partial 32-bit huge page support") > Signed-off-by: Wei Li > --- > arch/mips/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]