From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.4 15/15] regulator: da9052: Ensure enough delay time for .set_voltage_time_sel
Date: Sun, 4 Jul 2021 19:12:21 -0400 [thread overview]
Message-ID: <20210704231222.1492037-15-sashal@kernel.org> (raw)
In-Reply-To: <20210704231222.1492037-1-sashal@kernel.org>
From: Axel Lin <axel.lin@ingics.com>
[ Upstream commit a336dc8f683e5be794186b5643cd34cb28dd2c53 ]
Use DIV_ROUND_UP to prevent truncation by integer division issue.
This ensures we return enough delay time.
Also fix returning negative value when new_sel < old_sel.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Link: https://lore.kernel.org/r/20210618141412.4014912-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/regulator/da9052-regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index 12a25b40e473..fa9cb7df79de 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -258,7 +258,8 @@ static int da9052_regulator_set_voltage_time_sel(struct regulator_dev *rdev,
case DA9052_ID_BUCK3:
case DA9052_ID_LDO2:
case DA9052_ID_LDO3:
- ret = (new_sel - old_sel) * info->step_uV / 6250;
+ ret = DIV_ROUND_UP(abs(new_sel - old_sel) * info->step_uV,
+ 6250);
break;
}
--
2.30.2
prev parent reply other threads:[~2021-07-04 23:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 23:12 [PATCH AUTOSEL 4.4 01/15] spi: spi-topcliff-pch: Fix potential double free in pch_spi_process_messages() Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 02/15] spi: omap-100k: Fix the length judgment problem Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 03/15] crypto: nx - add missing MODULE_DEVICE_TABLE Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 04/15] media: cpia2: fix memory leak in cpia2_usb_probe Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 05/15] media: pvrusb2: fix warning in pvr2_i2c_core_done Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 06/15] crypto: qat - check return code of qat_hal_rd_rel_reg() Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 07/15] crypto: qat - remove unused macro in FW loader Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 08/15] media: v4l2-core: Avoid the dangling pointer in v4l2_fh_release Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 09/15] media: bt8xx: Fix a missing check bug in bt878_probe Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 10/15] mmc: via-sdmmc: add a check against NULL pointer dereference Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 11/15] crypto: shash - avoid comparing pointers to exported functions under CFI Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 12/15] media: dvb_net: avoid speculation from net slot Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 13/15] btrfs: make Private2 lifespan more consistent Sasha Levin
2021-07-04 23:12 ` [PATCH AUTOSEL 4.4 14/15] btrfs: disable build on platforms having page size 256K Sasha Levin
2021-07-04 23:12 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210704231222.1492037-15-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®