From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85A8C07E9D for ; Sun, 4 Jul 2021 23:23:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB3F36194B for ; Sun, 4 Jul 2021 23:23:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234654AbhGDXYx (ORCPT ); Sun, 4 Jul 2021 19:24:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:56966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234478AbhGDXPJ (ORCPT ); Sun, 4 Jul 2021 19:15:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CE89E61364; Sun, 4 Jul 2021 23:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625440353; bh=FSyh4ATv5z5J1QHnSLtm7oz7ME9uM7NWV2nCpkUkoMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ftmkFaJ40a2OrnhFy5TNEelyV5VjVk2RhEAcgW96OK87MGb7HZ3XuXORwDp+6kFbw DD7/jv7vrwXjpbpgKwUO9dIF5q1N49nIUIJ12TnFzfUNK93sZGz6vsvUJZ1Xb7BrNQ xJvvk8/6QbTAcdxQOdBl1ZlXgYd/5YN0BEhfSqONAKlqyDGwM+V7gHNn06cs3futgf BCg1GzK2PtEne23FLnF4l0PAmsAB6n3maRbNhuOumcu9E9zabTdNJ8D1dxKc+C7f7u 3AMi9rRN01qU3WvfI58pEErGaS8D1Bfl4xAXUEBcpEPWrqSqk6v8z7mFPFduhtHc/2 OKnwahW6cUsZg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lv Yunlong , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 08/15] media: v4l2-core: Avoid the dangling pointer in v4l2_fh_release Date: Sun, 4 Jul 2021 19:12:14 -0400 Message-Id: <20210704231222.1492037-8-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210704231222.1492037-1-sashal@kernel.org> References: <20210704231222.1492037-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Yunlong [ Upstream commit 7dd0c9e547b6924e18712b6b51aa3cba1896ee2c ] A use after free bug caused by the dangling pointer filp->privitate_data in v4l2_fh_release. See https://lore.kernel.org/patchwork/patch/1419058/. My patch sets the dangling pointer to NULL to provide robust. Signed-off-by: Lv Yunlong Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/v4l2-core/v4l2-fh.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-fh.c b/drivers/media/v4l2-core/v4l2-fh.c index 1d076deb05a9..ce844ecc3340 100644 --- a/drivers/media/v4l2-core/v4l2-fh.c +++ b/drivers/media/v4l2-core/v4l2-fh.c @@ -107,6 +107,7 @@ int v4l2_fh_release(struct file *filp) v4l2_fh_del(fh); v4l2_fh_exit(fh); kfree(fh); + filp->private_data = NULL; } return 0; } -- 2.30.2