From: Alexandre Courbot <acourbot@chromium.org>
To: Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Alexandre Courbot <acourbot@chromium.org>,
Tzung-Bi Shih <tzungbi@google.com>
Subject: [PATCH v6 02/14] media: mtk-vcodec: vdec: use helpers in VIDIOC_(TRY_)DECODER_CMD
Date: Mon, 5 Jul 2021 14:32:46 +0900 [thread overview]
Message-ID: <20210705053258.1614177-3-acourbot@chromium.org> (raw)
In-Reply-To: <20210705053258.1614177-1-acourbot@chromium.org>
Let's use the dedicated helpers to make sure we get the expected
behavior and remove redundant code.
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
index 8df8bcfe5e9c..1a633b485a69 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
@@ -484,18 +484,7 @@ static void mtk_vdec_worker(struct work_struct *work)
static int vidioc_try_decoder_cmd(struct file *file, void *priv,
struct v4l2_decoder_cmd *cmd)
{
- switch (cmd->cmd) {
- case V4L2_DEC_CMD_STOP:
- case V4L2_DEC_CMD_START:
- if (cmd->flags != 0) {
- mtk_v4l2_err("cmd->flags=%u", cmd->flags);
- return -EINVAL;
- }
- break;
- default:
- return -EINVAL;
- }
- return 0;
+ return v4l2_m2m_ioctl_try_decoder_cmd(file, priv, cmd);
}
--
2.32.0.93.g670b81a890-goog
next prev parent reply other threads:[~2021-07-05 5:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 5:32 [PATCH v6 00/14] media: mtk-vcodec: support for MT8183 decoder Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 01/14] media: mtk-vcodec: vdec: Support H264 profile control Alexandre Courbot
2021-07-05 5:32 ` Alexandre Courbot [this message]
2021-07-05 5:32 ` [PATCH v6 03/14] media: mtk-vcodec: vdec: clamp OUTPUT resolution to hardware limits Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 04/14] media: mtk-vcodec: make flush buffer reusable by encoder Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 05/14] media: mtk-vcodec: venc: support START and STOP commands Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 06/14] media: mtk-vcodec: vdec: move stateful ops into their own file Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 07/14] media: mtk-vcodec: vdec: handle firmware version field Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 08/14] media: mtk-vcodec: support version 2 of decoder firmware ABI Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 09/14] media: add Mediatek's MM21 format Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 10/14] media: mtk-vcodec: vdec: support stateless API Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 11/14] media: mtk-vcodec: vdec: support stateless H.264 decoding Alexandre Courbot
2021-07-20 10:52 ` Hans Verkuil
2021-08-05 11:51 ` Tzung-Bi Shih
2021-07-05 5:32 ` [PATCH v6 12/14] media: mtk-vcodec: vdec: add media device if using stateless api Alexandre Courbot
2021-07-19 16:22 ` Dafna Hirschfeld
2021-08-05 11:51 ` Tzung-Bi Shih
2021-07-05 5:32 ` [PATCH v6 13/14] dt-bindings: media: document mediatek,mt8183-vcodec-dec Alexandre Courbot
2021-07-05 5:32 ` [PATCH v6 14/14] media: mtk-vcodec: enable MT8183 decoder Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705053258.1614177-3-acourbot@chromium.org \
--to=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@google.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®