mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Gruber <j4n6ru@gmail.com>
To: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Jan Gruber <j4n6ru@gmail.com>
Subject: [PATCH] staging: rtl8188eu: remove unnecessary logging
Date: Mon,  5 Jul 2021 19:21:01 +0200	[thread overview]
Message-ID: <20210705172101.239899-1-j4n6ru@gmail.com> (raw)

This commit fixes the following checkpatch.pl issues:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
158: FILE: drivers/staging/rtl8188eu/os_dep/usb_intf.c:158:
+               pr_debug("===> %s\n", __func__);
---
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
177: FILE: drivers/staging/rtl8188eu/os_dep/usb_intf.c:177:
+       pr_debug("<=== %s\n", __func__);

and removes another line of unnecessary logging, which was not
identified by checkpatch.pl in an automated manner.

Signed-off-by: Jan Gruber <j4n6ru@gmail.com>
---
 drivers/staging/rtl8188eu/os_dep/usb_intf.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index b7e2692c35f3..fe8101c46808 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -155,7 +155,6 @@ void usb_intf_stop(struct adapter *padapter)
 static void rtw_dev_unload(struct adapter *padapter)
 {
 	if (padapter->bup) {
-		pr_debug("===> %s\n", __func__);
 		padapter->bDriverStopped = true;
 		if (padapter->xmitpriv.ack_tx)
 			rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_DRV_STOP);
@@ -173,8 +172,6 @@ static void rtw_dev_unload(struct adapter *padapter)
 
 		padapter->bup = false;
 	}
-
-	pr_debug("<=== %s\n", __func__);
 }
 
 static int rtw_suspend(struct usb_interface *pusb_intf, pm_message_t message)
@@ -455,8 +452,6 @@ static void rtw_dev_remove(struct usb_interface *pusb_intf)
 	struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
 	struct adapter *padapter = dvobj->if1;
 
-	pr_debug("+%s\n", __func__);
-
 	if (!pusb_intf->unregistering)
 		padapter->bSurpriseRemoved = true;
 
-- 
2.25.1


                 reply	other threads:[~2021-07-05 17:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210705172101.239899-1-j4n6ru@gmail.com \
    --to=j4n6ru@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®