From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DD6C11F91 for ; Tue, 6 Jul 2021 11:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8934761DCE for ; Tue, 6 Jul 2021 11:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239148AbhGFLke (ORCPT ); Tue, 6 Jul 2021 07:40:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:42520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235220AbhGFL3q (ORCPT ); Tue, 6 Jul 2021 07:29:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1BCFF61D8B; Tue, 6 Jul 2021 11:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570446; bh=fKUD4iN2+LvMxirRuESye6PTUzOC5Oed4ow7L8huVTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=urxgp5i04gZ7jreDQxIWZKZ41udg9MITlu5/joA+e9SQAc0/09qtiGnBaTZB+FV7S Mi0/VwI5jrzqv+NuI39glipahA+LA4qlILA9jZ3JOSfjjHpDX+7xzre91GLxzFxBqT BmSMAg8uFA80w0QZhDEqbxqO77gR7+wI3nStDBy3CQOH3lxs53HkdkyI7cboVwJKa2 PpCFrqIE4xuVFjMkaOr2/PxPdk8bTOha47BDAQaEQpqiwEZNDaw1bTO9XEu7lhJApn g7CKIe/ByqAraqTw4yNfgp6OHjVtWX54dYfOmnkZlHvz5IGFk/DOzOMGTnbnK3nc5C VhWJFWG9TVxpw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Hulk Robot , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.12 105/160] net: sched: fix error return code in tcf_del_walker() Date: Tue, 6 Jul 2021 07:17:31 -0400 Message-Id: <20210706111827.2060499-105-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706111827.2060499-1-sashal@kernel.org> References: <20210706111827.2060499-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 55d96f72e8ddc0a294e0b9c94016edbb699537e1 ] When nla_put_u32() fails, 'ret' could be 0, it should return error code in tcf_del_walker(). Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sched/act_api.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index f6d5755d669e..d17a66aab8ee 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -381,7 +381,8 @@ static int tcf_del_walker(struct tcf_idrinfo *idrinfo, struct sk_buff *skb, } mutex_unlock(&idrinfo->lock); - if (nla_put_u32(skb, TCA_FCNT, n_i)) + ret = nla_put_u32(skb, TCA_FCNT, n_i); + if (ret) goto nla_put_failure; nla_nest_end(skb, nest); -- 2.30.2