From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD30C07E96 for ; Tue, 6 Jul 2021 15:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7432661A0F for ; Tue, 6 Jul 2021 15:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232420AbhGFP3s (ORCPT ); Tue, 6 Jul 2021 11:29:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:51600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231773AbhGFP3p (ORCPT ); Tue, 6 Jul 2021 11:29:45 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8EF29619AE; Tue, 6 Jul 2021 15:27:06 +0000 (UTC) Date: Tue, 6 Jul 2021 11:26:59 -0400 From: Steven Rostedt To: Namhyung Kim Cc: Masami Hiramatsu , LKML , Ingo Molnar , Andrew Morton , Tom Zanussi , Daniel Bristot de Oliveira Subject: Re: [PATCH] tracing: Add "grouping" to histogram logic Message-ID: <20210706112659.74bc2b2a@oasis.local.home> In-Reply-To: References: <20210702175648.1172476c@gandalf.local.home> <20210703190725.8082fc92c244e26abec0bf8b@kernel.org> <20210703082713.3643b4d6@rorschach.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Jul 2021 13:32:53 -0700 Namhyung Kim wrote: > > Yeah, I just picked '-' but then realized it would conflict with other > > key words. > > Also we already have ".log2" flag for a logarithmic histrogram. > Then we might have something like "keys=FIELD.bucket=SIZE" > for linear histograms. I like the above idea. Tom, do you have any issue with this? -- Steve