From: "Luck, Tony" <tony.luck@intel.com>
To: Ding Hui <dinghui@sangfor.com.cn>
Cc: bp@alien8.de, bp@suse.de, naoya.horiguchi@nec.com,
osalvador@suse.de, peterz@infradead.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
hpa@zytor.com, youquan.song@intel.com, huangcun@sangfor.com.cn,
stable@vger.kernel.org
Subject: Re: [PATCH v2] x86/mce: Fix endless loop when run task works after #MC
Date: Tue, 6 Jul 2021 09:44:51 -0700 [thread overview]
Message-ID: <20210706164451.GA1289248@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <20210706121606.15864-1-dinghui@sangfor.com.cn>
On Tue, Jul 06, 2021 at 08:16:06PM +0800, Ding Hui wrote:
> Recently we encounter multi #MC on the same task when it's
> task_work_run() has not been called, current->mce_kill_me was
> added to task_works list more than once, that make a circular
> linked task_works, so task_work_run() will do a endless loop.
I saw the same and posted a similar fix a while back:
https://www.spinics.net/lists/linux-mm/msg251006.html
It didn't get merged because some validation tests began failing
around the same time. I'm now pretty sure I understand what happened
with those other tests.
I'll post my updated version (second patch in a three part series)
later today.
> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> + if (!cmpxchg(¤t->mce_kill_me.func, NULL, ch.func)) {
> + current->mce_addr = m->addr;
> + current->mce_kflags = m->kflags;
> + current->mce_ripv = !!(m->mcgstatus & MCG_STATUS_RIPV);
> + current->mce_whole_page = whole_page(m);
You don't need an atomic cmpxchg here (nor the WRITE_ONCE() to clear it).
The task is operating on its own task_struct. Nobody else should touch
the mce_kill_me field.
-Tony
next prev parent reply other threads:[~2021-07-06 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 12:16 Ding Hui
2021-07-06 16:44 ` Luck, Tony [this message]
2021-07-07 3:39 ` Ding Hui
2021-07-07 9:51 ` Ding Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706164451.GA1289248@agluck-desk2.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dinghui@sangfor.com.cn \
--cc=hpa@zytor.com \
--cc=huangcun@sangfor.com.cn \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®