From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02755C07E96 for ; Thu, 8 Jul 2021 07:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8083619BE for ; Thu, 8 Jul 2021 07:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229899AbhGHHih (ORCPT ); Thu, 8 Jul 2021 03:38:37 -0400 Received: from m12-15.163.com ([220.181.12.15]:43232 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbhGHHig (ORCPT ); Thu, 8 Jul 2021 03:38:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=cMheW nPV+Ne7z6zmDmh2HBf+TFVmVgbZ0iWS3s4DJ54=; b=G00cRHc8xFyvio61+davz HFu5kh+y/CbB66KLliCOwoWKJm068Gw4d6109U50Ph0M6rAmaSLaPOw9NHE0gDNs JUDxfz3HQzb7WGpx9NjJc4gs2fd2f68E+Kym38hf3CtQTUBXuNYh9AAwnQTnLpLE +nkIDDL3hpELrmq95NCIGA= Received: from localhost.localdomain (unknown [218.17.89.111]) by smtp11 (Coremail) with SMTP id D8CowAAXH697quZgw2xcAA--.51S2; Thu, 08 Jul 2021 15:34:29 +0800 (CST) From: ChunyouTang To: steven.price@arm.com Cc: robh@kernel.org, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ChunyouTang Subject: [PATCH v3] drm/panfrost:fix the exception name always "UNKNOWN" Date: Thu, 8 Jul 2021 15:34:06 +0800 Message-Id: <20210708073407.2015-1-tangchunyou@163.com> X-Mailer: git-send-email 2.30.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: D8CowAAXH697quZgw2xcAA--.51S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtw15Cr48Cw4rJr18JF4ktFb_yoWkZrg_ur 17ur9xXrsIyrn0kws2y3Z7uryFvryUXw48Aw1fGryDCa45C3s0gwn2vrs8Zr48Wa15CFn8 tanFvF1Fkry7KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU5oc_3UUUUU== X-Originating-IP: [218.17.89.111] X-CM-SenderInfo: 5wdqwu5kxq50rx6rljoofrz/1tbiZQXJUV8ZPobPkQAAsY Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ChunyouTang The exception_code in register is only 8 bits,So if fault_status in panfrost_gpu_irq_handler() don't (& 0xFF),it can't get correct exception reason. and it's better to show all of the register value to custom,so it's better fault_status don't (& 0xFF). Signed-off-by: ChunyouTang --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index 1fffb6a0b24f..d2d287bbf4e7 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -33,7 +33,7 @@ static irqreturn_t panfrost_gpu_irq_handler(int irq, void *data) address |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO); dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n", - fault_status & 0xFF, panfrost_exception_name(pfdev, fault_status & 0xFF), + fault_status, panfrost_exception_name(pfdev, fault_status & 0xFF), address); if (state & GPU_IRQ_MULTIPLE_FAULT) -- 2.25.1