From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70CAC07E9B for ; Sat, 10 Jul 2021 02:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C58D5613EB for ; Sat, 10 Jul 2021 02:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233810AbhGJC1X (ORCPT ); Fri, 9 Jul 2021 22:27:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:42882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233241AbhGJC0G (ORCPT ); Fri, 9 Jul 2021 22:26:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 031D8613ED; Sat, 10 Jul 2021 02:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625883799; bh=ZKJVrmLYGVPSJrHqQHBq6fK9ClMXludSvV3cqZNaBzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Up+dlVWqLtFsfSJ5ZvPnuEPab5OYeSJG5y+B/R59+/IGdsWQSQZPJtPjKH8Scx7N+ Eramb7DgDzE2sGrZ5NVUl+/WrqX6EWJ3TH/RqyirZY+GLxQQ/oOOfqrVdsxWHN82+S bX/WFAGABkpOJZCGNwQWc1hwKkgpGiLwZ3O4esdSgY/7XEKt1NQzVvsLIslS9QS+A9 rWunVa2j6bzWaXFI55KDULgZ+5V/tZvf5F0pleKtLNXIwwOZdHnA2Jln4HeONoT6GD bLOk1CmdNOoXbWcGdPkYYFOJTccgGGfBrnIZWJW6FX4WAqekNxs7U4PexPDqpdHjmD GQrZaMXbRJK0w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jaroslav Kysela , Mark Brown , Kuninori Morimoto , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.12 063/104] ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry() Date: Fri, 9 Jul 2021 22:21:15 -0400 Message-Id: <20210710022156.3168825-63-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710022156.3168825-1-sashal@kernel.org> References: <20210710022156.3168825-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jaroslav Kysela [ Upstream commit 12ffd726824a2f52486f72338b6fd3244b512959 ] In case, where the loops are not executed for a reason, the uninitialized variable 'err' is returned to the caller. Make code fully predictible and assign zero in the declaration. Signed-off-by: Jaroslav Kysela Cc: Mark Brown Cc: Kuninori Morimoto Link: https://lore.kernel.org/r/20210614071746.1787072-1-perex@perex.cz Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 14d85ca1e435..4a25a1e39831 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1695,7 +1695,7 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream, struct snd_soc_dpcm *dpcm; struct snd_soc_pcm_runtime *fe = asoc_substream_to_rtd(fe_substream); struct snd_soc_dai *fe_cpu_dai; - int err; + int err = 0; int i; /* apply symmetry for FE */ -- 2.30.2