From: kernel test robot <lkp@intel.com>
To: David Howells <dhowells@redhat.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH dhowells-fs] cachefiles: fscache_lru_cookie_timeout can be static
Date: Tue, 13 Jul 2021 16:32:03 +0800 [thread overview]
Message-ID: <20210713083203.GA18070@f95dff6026d9> (raw)
In-Reply-To: <202107131619.bni4kdJM-lkp@intel.com>
fs/fscache/cookie.c:34:14: warning: symbol 'fscache_lru_cookie_timeout' was not declared. Should it be static?
Fixes: 4bd5274decc6 ("cachefiles: Automatically close a file that's not in use after a while")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
cookie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c
index c6c3ce8be80d7..618b040e156b2 100644
--- a/fs/fscache/cookie.c
+++ b/fs/fscache/cookie.c
@@ -31,7 +31,7 @@ static DEFINE_SPINLOCK(fscache_cookie_lru_lock);
static DEFINE_TIMER(fscache_cookie_lru_timer, fscache_cookie_lru_timed_out);
static DECLARE_WORK(fscache_cookie_lru_work, fscache_cookie_lru_worker);
static const char fscache_cookie_stages[FSCACHE_COOKIE_STAGE__NR] = "-LCAIFMWRD";
-unsigned int fscache_lru_cookie_timeout = 10 * HZ;
+static unsigned int fscache_lru_cookie_timeout = 10 * HZ;
void fscache_print_cookie(struct fscache_cookie *cookie, char prefix)
{
prev parent reply other threads:[~2021-07-13 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 8:31 [dhowells-fs:fscache-iter-2 42/68] fs/fscache/cookie.c:34:14: sparse: sparse: symbol 'fscache_lru_cookie_timeout' was not declared. Should it be static? kernel test robot
2021-07-13 8:32 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713083203.GA18070@f95dff6026d9 \
--to=lkp@intel.com \
--cc=dhowells@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome