From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A9EC07E96 for ; Tue, 13 Jul 2021 15:19:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B4FE6135F for ; Tue, 13 Jul 2021 15:19:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237036AbhGMPV7 (ORCPT ); Tue, 13 Jul 2021 11:21:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:36958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236842AbhGMPV6 (ORCPT ); Tue, 13 Jul 2021 11:21:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9821561279; Tue, 13 Jul 2021 15:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626189548; bh=o2FbT+3a/2fjrT4VDqDNnVS3kQjSJg0Vd1gtxuu08lQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=ibH+gOskiaRS5kxHGp0f+vHuyLowOLMKrvQ2D6ZAY1JO7TUpxFCRk7iWWLm28KFMT OZnGwwHl77WsRYRxkmz0koVUam3DUNQzTQ6awPRe+jdtk+YjCbZRl/Q+hUA2cmdAgn pAOsbmJ2SIpjzdkhcL30BKHQaZbsokIZzmGkzuYhTarCwO0K77KsJGNyu75xqfD7tu tqkQY0gKWJhkhP9VDSt/Z+qh9dat+Lg4w5Ud64AQ2ch+IHBgIAqPs+DoV3Sj2hmOIJ VoiM6JJ8LxYMSE9GzaERnDZ3skeAl9MKpmu8o+GRWb17Sl1yd9mJOcIZbnb7qlcCGs oV83hGVfGA9xQ== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 6C2605C0367; Tue, 13 Jul 2021 08:19:08 -0700 (PDT) Date: Tue, 13 Jul 2021 08:19:08 -0700 From: "Paul E. McKenney" To: Mathieu Desnoyers Cc: zhouzhouyi@gmail.com, Josh Triplett , rostedt , Lai Jiangshan , "Joel Fernandes, Google" , rcu , linux-kernel Subject: Re: [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU_TRACE Message-ID: <20210713151908.GW4397@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20210713005645.8565-1-zhouzhouyi@gmail.com> <20210713041607.GU4397@paulmck-ThinkPad-P17-Gen-1> <520385500.15226.1626181744332.JavaMail.zimbra@efficios.com> <20210713131812.GV4397@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210713131812.GV4397@paulmck-ThinkPad-P17-Gen-1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 13, 2021 at 06:18:12AM -0700, Paul E. McKenney wrote: > On Tue, Jul 13, 2021 at 09:09:04AM -0400, Mathieu Desnoyers wrote: > > ----- On Jul 13, 2021, at 12:16 AM, paulmck paulmck@kernel.org wrote: > > > > > On Tue, Jul 13, 2021 at 08:56:45AM +0800, zhouzhouyi@gmail.com wrote: > > >> From: Zhouyi Zhou > > >> > > >> Hi Paul, > > >> > > >> During my studying of RCU, I did a grep in the kernel source tree. > > >> I found there are 3 places where the macro name CONFIG_TASKS_RCU_TRACE > > >> should be CONFIG_TASKS_TRACE_RCU instead. > > >> > > >> Without memory fencing, the idle/userspace task inspection may not > > >> be so accurate. > > >> > > >> Thanks for your constant encouragement for my studying. > > >> > > >> Best Wishes > > >> Zhouyi > > >> > > >> Signed-off-by: Zhouyi Zhou > > > > > > Good eyes, and those could cause real bugs, so thank you! > > > > Hi Paul, > > > > This makes me wonder: what is missing testing-wise in rcutorture to > > catch those issues with testing before they reach mainline ? > > My guess: Running on weakly ordered architectures. ;-) And another guess: A tool that identifies use of Kconfig options that are not defined in any Kconfig* file. Thanx, Paul