From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1626C07E9A for ; Wed, 14 Jul 2021 09:04:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C839611AC for ; Wed, 14 Jul 2021 09:04:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238196AbhGNJHp (ORCPT ); Wed, 14 Jul 2021 05:07:45 -0400 Received: from foss.arm.com ([217.140.110.172]:60120 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238113AbhGNJHo (ORCPT ); Wed, 14 Jul 2021 05:07:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F02A31B; Wed, 14 Jul 2021 02:04:53 -0700 (PDT) Received: from bogus (unknown [10.57.79.213]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 563143F774; Wed, 14 Jul 2021 02:04:52 -0700 (PDT) Date: Wed, 14 Jul 2021 10:03:53 +0100 From: Sudeep Holla To: Xiongfeng Wang Cc: james.morse@arm.com, gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org, bobo.shaobowang@huawei.com, Sudeep Holla Subject: Re: [PATCH v2] cacheinfo: clear cache_leaves(cpu) in free_cache_attributes() Message-ID: <20210714090353.6ncnqof74hwbx2gf@bogus> References: <1626226375-58730-1-git-send-email-wangxiongfeng2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1626226375-58730-1-git-send-email-wangxiongfeng2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 14, 2021 at 09:32:55AM +0800, Xiongfeng Wang wrote: > On ARM64, when PPTT(Processor Properties Topology Table) is not > implemented in ACPI boot, we will goto 'free_ci' with the following > print: > Unable to detect cache hierarchy for CPU 0 > > But some other codes may still use 'num_leaves' to iterate through the > 'info_list', such as get_cpu_cacheinfo_id(). If 'info_list' is NULL , it > would crash. So clear 'num_leaves' in free_cache_attributes(). > Reviewed-by: Sudeep Holla -- Regards, Sudeep