From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [GIT PULL] tracing: Add __string_len() and __assign_str_len() helpers
Date: Wed, 14 Jul 2021 18:13:18 -0400 [thread overview]
Message-ID: <20210714181318.735a496b@oasis.local.home> (raw)
In-Reply-To: <20210714175633.3b53346a@oasis.local.home>
On Wed, 14 Jul 2021 17:56:33 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> That "(len)+1" adds the extra byte for the '0'. Hence, it is similar to:
>
> dst = kmalloc(len + 1, GFP_KERNEL);
> strncpy(dst, src, len);
> dst[len] = '\0';
>
> Where the requirement is that you want to save len bytes of source into
> dst, where len must be at least the size of src.
Sorry, that should have read "len must be at most the size of src".
That is, the caller knows how big src is, and is telling the trace
event that all characters up to "len" exists.
-- Steve
prev parent reply other threads:[~2021-07-14 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 21:11 Steven Rostedt
2021-07-14 19:20 ` Linus Torvalds
2021-07-14 21:56 ` Steven Rostedt
2021-07-14 22:03 ` Steven Rostedt
2021-07-14 22:13 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714181318.735a496b@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®