mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
	Lars Poeschel <poeschel@lemonage.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] auxdisplay: charlcd: Drop unneeded terminator entry
Date: Thu, 15 Jul 2021 16:25:46 +0200	[thread overview]
Message-ID: <20210715142546.GG27830@1wt.eu> (raw)
In-Reply-To: <20210715132310.31514-1-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Thu, Jul 15, 2021 at 04:23:10PM +0300, Andy Shevchenko wrote:
> Besides 0 not being, strictly speaking, a pointer it's redundant after
> the actual terminator NULL entry. Drop the former for good.

It seems to me that there is confusion caused by the absence of
the field names:

>  static struct notifier_block panel_notifier = {
>  	panel_notify_sys,
=> this is notifier_fn_t notifier_call

> -	NULL,
=> this is struct notifier_block __rcu *next

> -	0
=> this is int priority

> +	NULL

So all values look OK, however they're terribly confusing. wouldn't you
prefer to propose a patch to name them instead ? This would be safer,
especially if the structure evolves in the future.

Thanks!
Willy

  reply	other threads:[~2021-07-15 14:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 13:23 Andy Shevchenko
2021-07-15 14:25 ` Willy Tarreau [this message]
2021-07-15 14:42   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210715142546.GG27830@1wt.eu \
    --to=w@1wt.eu \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=poeschel@lemonage.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome