From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872CFC636C8 for ; Thu, 15 Jul 2021 22:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A2D7613D2 for ; Thu, 15 Jul 2021 22:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbhGOWxq (ORCPT ); Thu, 15 Jul 2021 18:53:46 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:42939 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbhGOWxq (ORCPT ); Thu, 15 Jul 2021 18:53:46 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id CBB8E1C0002; Thu, 15 Jul 2021 22:50:49 +0000 (UTC) From: Miquel Raynal To: Zhihao Cheng , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com Subject: Re: [PATCH v2] mtd: mtd_blkdevs: Initialize rq.limits.discard_granularity Date: Fri, 16 Jul 2021 00:50:49 +0200 Message-Id: <20210715225049.66252-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210615093905.3473709-1-chengzhihao1@huawei.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'2b6d2833cd1d8a43a837a45da65860ef086443dc' Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-06-15 at 09:39:05 UTC, Zhihao Cheng wrote: > Since commit b35fd7422c2f8("block: check queue's limits.discard_granularity > in __blkdev_issue_discard()") checks rq.limits.discard_granularity in > __blkdev_issue_discard(), we may get following warnings on formatted ftl: > > WARNING: CPU: 2 PID: 7313 at block/blk-lib.c:51 > __blkdev_issue_discard+0x2a7/0x390 > > Reproducer: > 1. ftl_format /dev/mtd0 > 2. modprobe ftl > 3. mkfs.vfat /dev/ftla > 4. mount -odiscard /dev/ftla temp > 5. dd if=/dev/zero of=temp/tst bs=1M count=10 oflag=direct > 6. dd if=/dev/zero of=temp/tst bs=1M count=10 oflag=direct > > Fix it by initializing rq.limits.discard_granularity if device supports > discard operation. > > Signed-off-by: Zhihao Cheng Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel