From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Colin King <colin.king@canonical.com>
Cc: array@sonata.ens-lyon.org, initializers@sonata.ens-lyon.org,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: use C99 syntax for array initializers
Date: Fri, 16 Jul 2021 10:35:47 +0200 [thread overview]
Message-ID: <20210716083547.sm5uzd2wsklb65f5@begin> (raw)
In-Reply-To: <20210715163122.62220-1-colin.king@canonical.com>
Colin King, le jeu. 15 juil. 2021 17:31:22 +0100, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
>
> The older obsolete array initializer syntax is currently being used
> for some of the array elements. Fix this by using the preferred C99
> array initializers syntax.
>
> Fixes: 5b5140bf5182 ("speakup: Separate out translations for bright colors names")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/i18n.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
> index bc7b47d1876f..d62079b1661f 100644
> --- a/drivers/accessibility/speakup/i18n.c
> +++ b/drivers/accessibility/speakup/i18n.c
> @@ -90,13 +90,13 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
> [MSG_COLOR_YELLOW] = "yellow",
> [MSG_COLOR_WHITE] = "white",
> [MSG_COLOR_GREY] = "grey",
> - [MSG_COLOR_BRIGHTBLUE] "bright blue",
> - [MSG_COLOR_BRIGHTGREEN] "bright green",
> - [MSG_COLOR_BRIGHTCYAN] "bright cyan",
> - [MSG_COLOR_BRIGHTRED] "bright red",
> - [MSG_COLOR_BRIGHTMAGENTA] "bright magenta",
> - [MSG_COLOR_BRIGHTYELLOW] "bright yellow",
> - [MSG_COLOR_BRIGHTWHITE] "bright white",
> + [MSG_COLOR_BRIGHTBLUE] = "bright blue",
> + [MSG_COLOR_BRIGHTGREEN] = "bright green",
> + [MSG_COLOR_BRIGHTCYAN] = "bright cyan",
> + [MSG_COLOR_BRIGHTRED] = "bright red",
> + [MSG_COLOR_BRIGHTMAGENTA] = "bright magenta",
> + [MSG_COLOR_BRIGHTYELLOW] = "bright yellow",
> + [MSG_COLOR_BRIGHTWHITE] = "bright white",
>
> /* Names of key states. */
> [MSG_STATE_DOUBLE] = "double",
> --
> 2.31.1
>
prev parent reply other threads:[~2021-07-16 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 16:31 Colin King
2021-07-16 8:35 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716083547.sm5uzd2wsklb65f5@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=array@sonata.ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=initializers@sonata.ens-lyon.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®