mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH allisonhenderson-xfs_work] xfs: xfs_trans_attr_finish_update can be static
Date: Mon, 19 Jul 2021 11:44:42 +0800	[thread overview]
Message-ID: <20210719034442.GA51111@67baee1309a0> (raw)
In-Reply-To: <202107191127.kQqGprKw-lkp@intel.com>

fs/xfs/xfs_attr_item.c:292:1: warning: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
fs/xfs/xfs_attr_item.c:496:27: warning: symbol 'xfs_trans_get_attrd' was not declared. Should it be static?

Fixes: ba1114fc490c ("xfs: Implement attr logging and replay")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 xfs_attr_item.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
index eda6ae3a39880..7d77de9e12781 100644
--- a/fs/xfs/xfs_attr_item.c
+++ b/fs/xfs/xfs_attr_item.c
@@ -288,7 +288,7 @@ xfs_attrd_item_release(
  * transaction is marked dirty regardless of whether the operation succeeds or
  * fails to support the ATTRI/ATTRD lifecycle rules.
  */
-int
+static int
 xfs_trans_attr_finish_update(
 	struct xfs_delattr_context	*dac,
 	struct xfs_attrd_log_item	*attrdp,
@@ -493,7 +493,7 @@ xfs_attri_item_match(
 /*
  * This routine is called to allocate an "attr free done" log item.
  */
-struct xfs_attrd_log_item *
+static struct xfs_attrd_log_item *
 xfs_trans_get_attrd(struct xfs_trans		*tp,
 		  struct xfs_attri_log_item	*attrip)
 {

      reply	other threads:[~2021-07-19  3:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  3:44 [allisonhenderson-xfs_work:delayed_attrs_v21_extended 39/62] fs/xfs/xfs_attr_item.c:292:1: sparse: sparse: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static? kernel test robot
2021-07-19  3:44 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210719034442.GA51111@67baee1309a0 \
    --to=lkp@intel.com \
    --cc=allison.henderson@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®