From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>
Cc: Peter H Anvin <hpa@zytor.com>,
Dave Hansen <dave.hansen@intel.com>,
Tony Luck <tony.luck@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
Sean Christopherson <seanjc@google.com>,
Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/4] x86/tdx: Add #VE tracepoint
Date: Mon, 19 Jul 2021 21:33:35 -0700 [thread overview]
Message-ID: <20210720043338.2123695-2-sathyanarayanan.kuppuswamy@linux.intel.com> (raw)
In-Reply-To: <20210720043338.2123695-1-sathyanarayanan.kuppuswamy@linux.intel.com>
From: Sean Christopherson <sean.j.christopherson@intel.com>
Add tracepoint for tracing TDX guest #VE exceptions. It will dump
RIP, exit reason, exit qual, GPA, instruction length and instruction
info for each #VE exception occurred.
Also, make trace points RCU idle safe to avoid warnings when RCU
debugging is enabled.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
arch/x86/include/asm/trace/tdx.h | 51 ++++++++++++++++++++++++++++++++
arch/x86/kernel/tdx.c | 6 ++++
2 files changed, 57 insertions(+)
create mode 100644 arch/x86/include/asm/trace/tdx.h
diff --git a/arch/x86/include/asm/trace/tdx.h b/arch/x86/include/asm/trace/tdx.h
new file mode 100644
index 000000000000..e045e276009e
--- /dev/null
+++ b/arch/x86/include/asm/trace/tdx.h
@@ -0,0 +1,51 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#if !defined(_TRACE_TDX_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_TDX_H
+
+#include <linux/tracepoint.h>
+
+#include <uapi/asm/vmx.h>
+
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM tdx
+
+#ifdef CONFIG_INTEL_TDX_GUEST
+
+TRACE_EVENT(tdg_virtualization_exception,
+ TP_PROTO(u64 rip, u32 exit_reason, u64 exit_qual,
+ u64 gpa, u32 instr_len, u32 instr_info),
+ TP_ARGS(rip, exit_reason, exit_qual, gpa, instr_len,
+ instr_info),
+ TP_STRUCT__entry(
+ __field(u64, rip)
+ __field(u64, exit_qual)
+ __field(u64, gpa)
+ __field(u32, exit_reason)
+ __field(u32, instr_len)
+ __field(u32, instr_info)
+ ),
+ TP_fast_assign(
+ __entry->rip = rip;
+ __entry->exit_qual = exit_qual;
+ __entry->gpa = gpa;
+ __entry->exit_reason = exit_reason;
+ __entry->instr_len = instr_len;
+ __entry->instr_info = instr_info;
+ ),
+ TP_printk("reason %s rip 0x%016llx len %u info 0x%08x qual 0x%016llx gpa 0x%016llx",
+ __print_symbolic(__entry->exit_reason, VMX_EXIT_REASONS),
+ __entry->rip, __entry->instr_len, __entry->instr_info,
+ __entry->exit_qual, __entry->gpa
+ )
+ );
+
+#endif // CONFIG_INTEL_TDX_GUEST
+
+#undef TRACE_INCLUDE_PATH
+#define TRACE_INCLUDE_PATH asm/trace/
+#undef TRACE_INCLUDE_FILE
+#define TRACE_INCLUDE_FILE tdx
+#endif /* _TRACE_TDX_H */
+
+/* This part must be outside protection */
+#include <trace/define_trace.h>
diff --git a/arch/x86/kernel/tdx.c b/arch/x86/kernel/tdx.c
index 5ccdfeb01a8d..6d55a1bc7000 100644
--- a/arch/x86/kernel/tdx.c
+++ b/arch/x86/kernel/tdx.c
@@ -16,6 +16,9 @@
#include <linux/sched/signal.h> /* force_sig_fault() */
#include <linux/swiotlb.h>
+#define CREATE_TRACE_POINTS
+#include <asm/trace/tdx.h>
+
/* TDX Module call Leaf IDs */
#define TDINFO 1
#define TDGETVEINFO 3
@@ -407,6 +410,9 @@ int tdg_handle_virtualization_exception(struct pt_regs *regs,
unsigned long val;
int ret = 0;
+ trace_tdg_virtualization_exception_rcuidle(regs->ip, ve->exit_reason,
+ ve->exit_qual, ve->gpa, ve->instr_len, ve->instr_info);
+
switch (ve->exit_reason) {
case EXIT_REASON_HLT:
tdg_halt();
--
2.25.1
next prev parent reply other threads:[~2021-07-20 4:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 4:33 [PATCH v2 0/4] Add TDX Guest Support (Debug support) Kuppuswamy Sathyanarayanan
2021-07-20 4:33 ` Kuppuswamy Sathyanarayanan [this message]
2021-07-20 4:33 ` [PATCH v2 2/4] x86/tdx: Add TDCALL tracepoint Kuppuswamy Sathyanarayanan
2021-07-20 4:33 ` [PATCH v2 3/4] x86/tdx: Expose TDX Guest #VE count in /proc/interrupts Kuppuswamy Sathyanarayanan
2021-07-20 4:33 ` [PATCH v2 4/4] x86/tdx: Add tdg_debug_enabled() interface Kuppuswamy Sathyanarayanan
2021-07-20 16:34 ` Dave Hansen
2021-07-20 17:37 ` Kuppuswamy, Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720043338.2123695-2-sathyanarayanan.kuppuswamy@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=knsathya@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®