From: "Paul E. McKenney" <paulmck@kernel.org>
To: Willy Tarreau <w@1wt.eu>
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: nolibc and __attribute__((__unused__))
Date: Wed, 21 Jul 2021 13:53:33 -0700 [thread overview]
Message-ID: <20210721205333.GU4397@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20210721203916.GC27330@1wt.eu>
On Wed, Jul 21, 2021 at 10:39:16PM +0200, Willy Tarreau wrote:
> Hi Paul!
>
> On Wed, Jul 21, 2021 at 01:33:49PM -0700, Paul E. McKenney wrote:
> > Hello!
> >
> > My guess is that I should ignore the following checkpatch complaint on
> > the assumption that checkpatch doesn't realize that this is not built
> > as part of the Linux kernel. But if my guess is incorrect, please let
> > me know, as it is a trivial change to make.
> (...)
> > WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
> > #24: FILE: tools/include/nolibc/nolibc.h:2246:
> > +static __attribute__((unused))
>
> Yes you're totally right, we try to keep both trees in sync by minimizing
> the differences between the two, so as long as that doesn't become a
> problem I prefer to keep the warning than having to manually apply
> future patches due to context differences.
Very well, and I will continue to ignore this sort of warning from
checkpatch for nolibc files.
Thanx, Paul
prev parent reply other threads:[~2021-07-21 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 20:33 Paul E. McKenney
2021-07-21 20:39 ` Willy Tarreau
2021-07-21 20:53 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721205333.GU4397@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®