From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F911C4320A for ; Thu, 22 Jul 2021 19:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3659060E74 for ; Thu, 22 Jul 2021 19:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbhGVSuF (ORCPT ); Thu, 22 Jul 2021 14:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbhGVSuE (ORCPT ); Thu, 22 Jul 2021 14:50:04 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97DDBC061575 for ; Thu, 22 Jul 2021 12:30:37 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id a12so10175509lfb.7 for ; Thu, 22 Jul 2021 12:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ojab.ru; s=ojab; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ki3EP487cHlKuJ8BiqZxtwSYC7B4SnWzmdp/UL5pFnk=; b=mfpcCjAgt8VnvUgRMgumJXzjEXRNrkL3py5aTk+1LV/vsKMx0cqZvEixFsf0yc8KFe ETx+LR45QTT4sYGWN7VSFazuAe3C1x3wB9pazgl6tZDiTr9Kdd76pt1bCqhWcTXE0Ugm 8CuS7rIlHJwhGjVad+BVJUQix1FuYzrJNbLzNfziUWy2b+7vBy3N5zg4gQ3VgEh612f1 mS+mNWCOEHOPnOU0jSVAvvlIjgXnqgGkwPkyb0gOgllWevhGevwpIl3c3Po+CGYZjQlZ ipsBTzQrffsE67Sjbu9TjTyXCVUJ9zf1MX45+DmqLcseV7Ibbd/yhUCG/WQrP5CtjEUI JDYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ki3EP487cHlKuJ8BiqZxtwSYC7B4SnWzmdp/UL5pFnk=; b=TNdwFFNeX5BhhpuO3DzxjQVh+b2XeIaM8Fuf6xzJU+Y5OkZZ+vIztegrtr8g3SSqdK yUyHLzHMXwRW9KtWqzluzl2qOSf1GaOsEMrVSDBiupjmA+EOuyvxSp18NnhQZpF1TXsu OWhDhpVYHK8S+H7/5cD/aZ5xgLgDjjXvT6cTd8zVemLt6Mr7tJ7T0WunDabMFufvhJVS K2QgbzADaaXy3k3UfnMAV/7AvelEQZADqrvV9Xurfix9pXtDIjm1YjWOWAFL3aO+l9CU rZ9XyFxAcq8tzYQw3ytLYSREFJ5qniLqOM+cjQf3gK5gZ4sxyqgDPPXfCcwNoz8MWsbL pHsQ== X-Gm-Message-State: AOAM532DA+qNm1bDevReb4j/290Ck01OPTkBgYMWDXlVfYWIXupcZJNZ KAtLWJWPWjOEWF12nHGkl9SR1w== X-Google-Smtp-Source: ABdhPJwEsuMO5wqqYtkztd0Y+meQb5roqH3WyT+0VBq7dzbd2tAOaqH0lRXxnfnnpX20pzcB6cON4w== X-Received: by 2002:a05:6512:3393:: with SMTP id h19mr649086lfg.58.1626982236011; Thu, 22 Jul 2021 12:30:36 -0700 (PDT) Received: from ojab.ru ([2a03:e2c0:1ce::2]) by smtp.gmail.com with ESMTPSA id e5sm3198061ljk.51.2021.07.22.12.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jul 2021 12:30:35 -0700 (PDT) From: ojab To: Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: ojab , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ath10k: don't fail if IRAM write fails Date: Thu, 22 Jul 2021 19:29:37 +0000 Message-Id: <20210722192937.4847-1-ojab@ojab.ru> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After reboot with kernel & firmware updates I found `failed to copy target iram contents:` in dmesg and missing wlan interfaces for both of my QCA9984 compex cards. Rolling back kernel/firmware didn't fixed it, so while I have no idea what's actually happening, I don't see why we should fail in this case, looks like some optional firmware ability that could be skipped. Also with additional logging there is ``` [ 6.839858] ath10k_pci 0000:04:00.0: No hardware memory [ 6.841205] ath10k_pci 0000:04:00.0: failed to copy target iram contents: -12 [ 6.873578] ath10k_pci 0000:07:00.0: No hardware memory [ 6.875052] ath10k_pci 0000:07:00.0: failed to copy target iram contents: -12 ``` so exact branch could be seen. --- drivers/net/wireless/ath/ath10k/core.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 2f9be182fbfb..d9fd5294e142 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -2691,8 +2691,10 @@ static int ath10k_core_copy_target_iram(struct ath10k *ar) u32 len, remaining_len; hw_mem = ath10k_coredump_get_mem_layout(ar); - if (!hw_mem) + if (!hw_mem) { + ath10k_warn(ar, "No hardware memory"); return -ENOMEM; + } for (i = 0; i < hw_mem->region_table.size; i++) { tmp = &hw_mem->region_table.regions[i]; @@ -2702,8 +2704,10 @@ static int ath10k_core_copy_target_iram(struct ath10k *ar) } } - if (!mem_region) + if (!mem_region) { + ath10k_warn(ar, "No memory region"); return -ENOMEM; + } for (i = 0; i < ar->wmi.num_mem_chunks; i++) { if (ar->wmi.mem_chunks[i].req_id == @@ -2917,7 +2921,6 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode, if (status) { ath10k_warn(ar, "failed to copy target iram contents: %d", status); - goto err_hif_stop; } } -- 2.32.0