From: "Ivan T. Ivanov" <iivanov@suse.de>
To: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>, Emma Anholt <emma@anholt.net>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/vc4: hdmi: Add debugfs prefix
Date: Fri, 23 Jul 2021 09:24:14 +0200 [thread overview]
Message-ID: <20210723072414.17590-1-iivanov@suse.de> (raw)
Without prefix debugfs can't properly create component
debug information tree when driver register more than
one component per device, in this case two. Fix this.
debugfs: Directory 'fef00700.hdmi' with parent 'vc4-hdmi-0' already present!
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index aab1b36ceb3c..62b057f88df5 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -1523,6 +1523,9 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
struct snd_soc_dai_link *dai_link = &vc4_hdmi->audio.link;
struct snd_soc_card *card = &vc4_hdmi->audio.card;
struct device *dev = &vc4_hdmi->pdev->dev;
+#ifdef CONFIG_DEBUG_FS
+ struct snd_soc_component *comp;
+#endif
const __be32 *addr;
int index;
int ret;
@@ -1577,6 +1580,16 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
return ret;
}
+#ifdef CONFIG_DEBUG_FS
+ comp = snd_soc_lookup_component(dev, vc4_hdmi_audio_cpu_dai_comp.name);
+ if (comp)
+ comp->debugfs_prefix = "cpu";
+
+ comp = snd_soc_lookup_component(dev, vc4_hdmi_audio_component_drv.name);
+ if (comp)
+ comp->debugfs_prefix = "codec";
+#endif
+
dai_link->cpus = &vc4_hdmi->audio.cpu;
dai_link->codecs = &vc4_hdmi->audio.codec;
dai_link->platforms = &vc4_hdmi->audio.platform;
--
2.32.0
next reply other threads:[~2021-07-23 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 7:24 Ivan T. Ivanov [this message]
2021-07-28 11:54 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723072414.17590-1-iivanov@suse.de \
--to=iivanov@suse.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®