From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F93C4338F for ; Fri, 23 Jul 2021 14:06:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26EE260EB4 for ; Fri, 23 Jul 2021 14:06:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235345AbhGWNZh (ORCPT ); Fri, 23 Jul 2021 09:25:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:34064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233663AbhGWNZg (ORCPT ); Fri, 23 Jul 2021 09:25:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5EAE7608FE; Fri, 23 Jul 2021 14:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627049169; bh=aOlW7HflLLCB43LLa1QBe7XH3wZ0g0g9L9bhVoxp6OM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dCgPkn06oMpesYXjNUonsk8Oee7bC8Zioxog0T7k3BHdW9g8fFGAVP4NOg1/01Hat khE+bqmg/0Yi/2JI0uTGZ4KXAO6P5NnljWbhhGMDdK1Nexoa09fuRb/z5O4YlG0sCq DzViw2a+XjG3bVb0ByMSSFr2YDfyqMwQ5Zetl3p+IE7cgj3Kbs91XBCqn9ubpvkek+ C4QIua1dVqNK3jPPBtMSl3c1g1JJq/lFPjSYGIfWeplLm9mcsm7XVRhuSL/plD4Rzu xz27MzUyjNBY0UqhDM+FsXfLuYWrF4eB+kqJU50zh+onyDGVjgJgc4iGnuXp+XG47k w7Msjxyf+eNDA== Date: Fri, 23 Jul 2021 15:06:02 +0100 From: Mark Brown To: Matthias Schiffer Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , linux-arm-kernel@lists.infradead.org, Lee Jones , Arnd Bergmann Subject: Re: Duplicate calls to regmap_debugfs_init() through regmap_attach_dev() Message-ID: <20210723140602.GE5221@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EXKGNeO8l0xGFBjy" Content-Disposition: inline In-Reply-To: X-Cookie: Integrity has no need for rules. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EXKGNeO8l0xGFBjy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 19, 2021 at 03:53:38PM +0200, Matthias Schiffer wrote: > With recent kernels (observed on v5.10.y, but the code doesn't look > significantly different on master/next) I've seen the following message > on boot on i.MX6UL SoCs: That's not recent but anyway... > It seems to me that there is no correct way to use regmap_attach_dev() > from outside of __regmap_init(). In particular on a syscon regmap that > may be shared between different drivers, setting map->dev looks wrong > to me. Yes, trying to set the device on a regmap that already has a device is not a good idea, if the syscon code is doing it transparently as part of lookup then syscon users shouldn't do it by hand. --EXKGNeO8l0xGFBjy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmD6zMkACgkQJNaLcl1U h9DdOQf+IFCCmuyjvdU07qtZveGKpzQ3rYjXfzpvmcAgUP45gWCpomIlz2rSQjcS bUHdGQ/pUQNx7IY7NjbMJrCi2EiolGihLU7WB77VhT1tHItzx2MtohzpC/Q5veSm t2YZHAW85GOsqM6OfSbled1s+J8jD+Gsn1iz5sDcbKtIRDq0DaYtD1Peh+etW3SB P9bYqQNBhDYbTVYohISzRarAerdUSNd3DfmTrFjVbdsvAonRAKTGTcA89rTonTC8 5PdIuQ2bxdvwj53w1N+Kox6/0TH9wDAzHdSsCQmWL/3bUdwFutX6RF8SWzoY3U/W qrCXBWuT2Jfze14QuArNDg6a96UBOQ== =43yC -----END PGP SIGNATURE----- --EXKGNeO8l0xGFBjy--