From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A39C432BE for ; Fri, 23 Jul 2021 14:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 016B160EFD for ; Fri, 23 Jul 2021 14:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235467AbhGWONo (ORCPT ); Fri, 23 Jul 2021 10:13:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30137 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235351AbhGWONa (ORCPT ); Fri, 23 Jul 2021 10:13:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627052043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KzcnGLaacDgNN8JHkByoexh8GLTQOigyRJDFx1KyDyI=; b=gkD+OTzKaN9ITGSUy4rUXoFnZ65UbIwaTaOH8oLurWIrQkcPXqgUqqMCaxYFU971Fdp//t wlB0IAFDRiFrWjZJwvPntAmvPlh6kDPzxAHCE+zwn7IhG5lNUteII0yvvApC1BGy5Raur9 YS2aad1lG5B/9/ksBpblgqMVAKLbwhM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-W4e0NKjoM62qwxhbK2OT6A-1; Fri, 23 Jul 2021 10:54:02 -0400 X-MC-Unique: W4e0NKjoM62qwxhbK2OT6A-1 Received: by mail-wm1-f70.google.com with SMTP id c2-20020a7bc8420000b0290238db573ab7so1503767wml.5 for ; Fri, 23 Jul 2021 07:54:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KzcnGLaacDgNN8JHkByoexh8GLTQOigyRJDFx1KyDyI=; b=eukcg+UOZLMVVxLkkPKB3WrrPItR+2UXmKbnR5ardj80yQNzyaAECdPBcmeANbc6Zs lD2EfgNL/yLq8/MdEQ4ycOWuGOF6Xhmx13P9BkccZpZu6SogGzRsnO/py6p+qaswVmkh z4e9BsAYchrCX8NEtZiqWkhPiExGnquL6bfYYOiH08nY3tffGET8pgxPcNU8ZYcaiHLq EERgZNXV2Rh55cOwj+EXgU2qzK0JIFC8O+/7MDSVtfgfg9FGqgsHHP7d0Dup76HNCeCc LNjteF56Cteawu7EeP9XluTqUhzQAiXYws/B3UV678FAPYiHecps7/K6U84BjsW/JxVF Izzg== X-Gm-Message-State: AOAM532VmA+l7xVv2Qa6X6QvWj0ETyfdEdvZKxVeNLw4rwFsIErWa+Ec Ht0B5n5Y9iu0MMltabCxpJyHNJOmjN6vFK9w7mvpGVPk9qUQ/un2ZlN1NDT+hSo/H9GFE8ScCrm NgBnHTjPU2fvSxn+96a47sipf X-Received: by 2002:a7b:cb4d:: with SMTP id v13mr3594839wmj.68.1627052041371; Fri, 23 Jul 2021 07:54:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg3/rHxC6b3F9kv0Z/oQV6K4OuNHE8KmjmwppyGJt73QDUzut6gjIGYOsMCZq0dX32zZczvQ== X-Received: by 2002:a7b:cb4d:: with SMTP id v13mr3594830wmj.68.1627052041247; Fri, 23 Jul 2021 07:54:01 -0700 (PDT) Received: from vian.redhat.com ([79.116.5.179]) by smtp.gmail.com with ESMTPSA id w18sm35594863wrg.68.2021.07.23.07.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 07:54:01 -0700 (PDT) From: Nicolas Saenz Julienne To: bristot@kernel.org Cc: axboe@kernel.dk, bigeasy@linutronix.de, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, stable@vger.kernel.org, tglx@linutronix.de, viro@zeniv.linux.org.uk, zhe.he@windriver.com, Nicolas Saenz Julienne Subject: Re: [PATCH] eventfd: protect eventfd_wake_count with a local_lock Date: Fri, 23 Jul 2021 16:53:04 +0200 Message-Id: <20210723145303.272822-1-nsaenzju@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <523c91c4a30f21295508004c81cd2e46ccc37dc2.1626680553.git.bristot@kernel.org> References: <523c91c4a30f21295508004c81cd2e46ccc37dc2.1626680553.git.bristot@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Jul 2021 09:54:52 +0200, Daniel Bristot de Oliveira wrote: > eventfd_signal assumes that spin_lock_irqsave/spin_unlock_irqrestore is > non-preemptable and therefore increments and decrements the percpu > variable inside the critical section. > > This obviously does not fly with PREEMPT_RT. If eventfd_signal is > preempted and an unrelated thread calls eventfd_signal, the result is > a spurious WARN. To avoid this, protect the percpu variable with a > local_lock. > > Reported-by: Daniel Bristot de Oliveira > Fixes: b5e683d5cab8 ("eventfd: track eventfd_signal() recursion depth") > Cc: He Zhe > Cc: Jens Axboe > Cc: Alexander Viro > Cc: Thomas Gleixner > Cc: Sebastian Andrzej Siewior > Cc: stable@vger.kernel.org > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Co-developed-by: Paolo Bonzini > Signed-off-by: Paolo Bonzini > Signed-off-by: Daniel Bristot de Oliveira > --- Tested-by: Nicolas Saenz Julienne Thanks! -- Nicolás Sáenz