From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBA8C432BE for ; Sat, 24 Jul 2021 15:25:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C76B60E96 for ; Sat, 24 Jul 2021 15:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbhGXOoo (ORCPT ); Sat, 24 Jul 2021 10:44:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:36536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhGXOon (ORCPT ); Sat, 24 Jul 2021 10:44:43 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C879A6056C; Sat, 24 Jul 2021 15:25:10 +0000 (UTC) Date: Sat, 24 Jul 2021 16:27:41 +0100 From: Jonathan Cameron To: Tang Bin Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, broonie@kernel.org, lgirdwood@gmail.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhang Shengju Subject: Re: [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code Message-ID: <20210724162741.15a8b8b6@jic23-huawei> In-Reply-To: <20210720125945.11548-1-tangbin@cmss.chinamobile.com> References: <20210720125945.11548-1-tangbin@cmss.chinamobile.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jul 2021 20:59:45 +0800 Tang Bin wrote: > Use the defined variable "dev" to make the code cleaner. > > Co-developed-by: Zhang Shengju > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied. Thanks, Jonathan > --- > drivers/iio/adc/fsl-imx25-gcq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c > index d28976f21..01fe5b137 100644 > --- a/drivers/iio/adc/fsl-imx25-gcq.c > +++ b/drivers/iio/adc/fsl-imx25-gcq.c > @@ -192,11 +192,11 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev, > */ > priv->vref[MX25_ADC_REFP_INT] = NULL; > priv->vref[MX25_ADC_REFP_EXT] = > - devm_regulator_get_optional(&pdev->dev, "vref-ext"); > + devm_regulator_get_optional(dev, "vref-ext"); > priv->vref[MX25_ADC_REFP_XP] = > - devm_regulator_get_optional(&pdev->dev, "vref-xp"); > + devm_regulator_get_optional(dev, "vref-xp"); > priv->vref[MX25_ADC_REFP_YP] = > - devm_regulator_get_optional(&pdev->dev, "vref-yp"); > + devm_regulator_get_optional(dev, "vref-yp"); > > for_each_child_of_node(np, child) { > u32 reg; > @@ -298,7 +298,7 @@ static int mx25_gcq_probe(struct platform_device *pdev) > int ret; > int i; > > - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv)); > + indio_dev = devm_iio_device_alloc(dev, sizeof(*priv)); > if (!indio_dev) > return -ENOMEM; >