From: Christoph Hellwig <hch@lst.de>
To: Kirti Wankhede <kwankhede@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] vfio/mdev: don't warn if ->request is not set
Date: Mon, 26 Jul 2021 16:35:24 +0200 [thread overview]
Message-ID: <20210726143524.155779-3-hch@lst.de> (raw)
In-Reply-To: <20210726143524.155779-1-hch@lst.de>
Only a single driver actually sets the ->request method, so don't print
a scary warning if it isn't.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/vfio/mdev/mdev_core.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
index b16606ebafa1..b314101237fe 100644
--- a/drivers/vfio/mdev/mdev_core.c
+++ b/drivers/vfio/mdev/mdev_core.c
@@ -138,10 +138,6 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops)
if (!dev)
return -EINVAL;
- /* Not mandatory, but its absence could be a problem */
- if (!ops->request)
- dev_info(dev, "Driver cannot be asked to release device\n");
-
mutex_lock(&parent_list_lock);
/* Check for duplicate */
--
2.30.2
next prev parent reply other threads:[~2021-07-26 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 14:35 two small mdev fixups Christoph Hellwig
2021-07-26 14:35 ` [PATCH 1/2] vfio/mdev: turn mdev_init into a subsys_initcall Christoph Hellwig
2021-07-26 17:00 ` Cornelia Huck
2021-07-26 23:06 ` Jason Gunthorpe
2021-07-26 14:35 ` Christoph Hellwig [this message]
2021-07-26 17:07 ` [PATCH 2/2] vfio/mdev: don't warn if ->request is not set Cornelia Huck
2021-07-26 23:09 ` Jason Gunthorpe
2021-07-26 23:28 ` Alex Williamson
2021-07-27 6:04 ` Cornelia Huck
2021-07-27 17:32 ` Jason Gunthorpe
2021-07-27 18:53 ` Alex Williamson
2021-07-27 19:03 ` Jason Gunthorpe
2021-07-27 19:25 ` Alex Williamson
2021-07-26 23:07 ` Jason Gunthorpe
2021-08-03 18:45 ` two small mdev fixups Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726143524.155779-3-hch@lst.de \
--to=hch@lst.de \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®