From: Keith Busch <kbusch@kernel.org>
To: shiva.linuxworks@gmail.com
Cc: rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com,
linux-pm@vger.kernel.org, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org,
Shivamurthy Shastri <sshivamurthy@micron.com>
Subject: Re: [PATCH v2 0/2] Abrupt Shutdown for NVMe SSD
Date: Mon, 26 Jul 2021 08:24:34 -0700 [thread overview]
Message-ID: <20210726152434.GA2024939@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <20210726132223.1661-1-sshivamurthy@micron.com>
On Mon, Jul 26, 2021 at 01:22:21PM +0000, shiva.linuxworks@gmail.com wrote:
> In the platform with a limited backup power supply, devices like NVMe
> SSD does unsafe shutdown.
>
> These two patches address this issue by adding a power loss imminent
> flag. The platform will enable the power loss imminent flag if the
> platform's power is running on the limited backup power supply. During
> the shutdown, the driver checks this information and pwerforms the
> abrupt shutdown.
I think the pm framework and nvme usage are ok, but you need a platform
specific caller to set the new power loss flag before this should be
considered, otherwise this is just unreachable code.
next prev parent reply other threads:[~2021-07-26 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 13:22 shiva.linuxworks
2021-07-26 13:22 ` [PATCH v2 1/2] PM: enable support for imminent power loss shiva.linuxworks
2021-07-26 19:41 ` Pavel Machek
2021-07-26 20:16 ` Keith Busch
2021-07-26 13:22 ` [PATCH v2 2/2] nvme: Add abrupt shutdown support shiva.linuxworks
2021-07-26 16:07 ` kernel test robot
2021-07-26 16:43 ` kernel test robot
2021-07-26 15:24 ` Keith Busch [this message]
2021-07-29 10:37 ` [EXT] Re: [PATCH v2 0/2] Abrupt Shutdown for NVMe SSD Shivamurthy Shastri (sshivamurthy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726152434.GA2024939@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sagi@grimberg.me \
--cc=shiva.linuxworks@gmail.com \
--cc=sshivamurthy@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®