From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F1C8C432BE for ; Wed, 28 Jul 2021 14:32:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5565D60F91 for ; Wed, 28 Jul 2021 14:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236788AbhG1Obc (ORCPT ); Wed, 28 Jul 2021 10:31:32 -0400 Received: from foss.arm.com ([217.140.110.172]:57756 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237379AbhG1O1r (ORCPT ); Wed, 28 Jul 2021 10:27:47 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8B181042; Wed, 28 Jul 2021 07:27:45 -0700 (PDT) Received: from bogus (unknown [10.57.37.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA7583F70D; Wed, 28 Jul 2021 07:27:41 -0700 (PDT) Date: Wed, 28 Jul 2021 15:26:25 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v6 08/17] firmware: arm_scmi: Add priv parameter to scmi_rx_callback Message-ID: <20210728142625.zbx7zbeffwsksjl5@bogus> References: <20210712141833.6628-1-cristian.marussi@arm.com> <20210712141833.6628-9-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712141833.6628-9-cristian.marussi@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 12, 2021 at 03:18:24PM +0100, Cristian Marussi wrote: > Add a new opaque void *priv parameter to scmi_rx_callback which can be > optionally provided by the transport layer when invoking scmi_rx_callback > and that will be passed back to the transport layer in xfer->priv. > > This can be used by transports that needs to keep track of their specific > data structures together with the valid xfers. > This change looks simple but doesn't make sense on its own. I assume you don't want to add all these in the patch making use of priv which makes sense. Not sure if the next patch uses it, but I prefer to keep them as close as possible if it is not too much of a hassle. -- Regards, Sudeep