From: Herbert Xu <herbert@gondor.apana.org.au>
To: yajun.deng@linux.dev
Cc: davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "net: Get rid of consume_skb when tracing is off"
Date: Thu, 29 Jul 2021 12:03:03 +0800 [thread overview]
Message-ID: <20210729040303.GA7009@gondor.apana.org.au> (raw)
In-Reply-To: <177cd530dcb2c9f4d09a2b23fdbbc71a@linux.dev>
On Thu, Jul 29, 2021 at 04:01:28AM +0000, yajun.deng@linux.dev wrote:
>
> if we don't define CONFIG_TRACEPOINTS, consume_skb() wolud called kfree_skb(), there have
> trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is also a trace function. So we
> can trace consume_skb() even if we don't define CONFIG_TRACEPOINTS.
> This patch "net: Get rid of consume_skb when tracing is off" does not seem to be effective.
The point of my patch was to get rid of consume_skb because its
only purpose is to provide extra information for tracing. If you're
not tracing then you don't need that extra information (and overhead).
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-07-29 4:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 3:56 Yajun Deng
2021-07-28 12:52 ` Herbert Xu
2021-07-29 4:01 ` yajun.deng
2021-07-29 4:03 ` Herbert Xu [this message]
2021-07-29 4:10 ` yajun.deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729040303.GA7009@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®